Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use bigquery-magics package for the %%bigquery magic #1965

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jun 27, 2024

Deprecates version of %%bigquery magic in this package.

Note: I keep the implementation intact to reduce disruption for folks that don't install the ipython extras.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes googleapis/python-bigquery-magics#14
🦕

@tswast tswast requested review from a team as code owners June 27, 2024 21:03
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jun 27, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jun 27, 2024
Copy link
Contributor

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor QUESTION/PREFERENCE.

Approving.

Comment on lines 27 to 29
# TODO: Enable 3.10 once there is a geopandas/fiona release.
# https://github.com/Toblerity/Fiona/issues/1043
"3.10",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QUESTION/PREFERENCE:
This issue appears to be closed. I am not clear on what release we need to see from Fiona. This issue was closed on Nov 21, 2021.
They currently claim to require 3.8 and above.
If it is not an issue, I recommend we remove this statement.

Suggested change
# TODO: Enable 3.10 once there is a geopandas/fiona release.
# https://github.com/Toblerity/Fiona/issues/1043
"3.10",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@tswast tswast merged commit 60128a5 into main Jul 10, 2024
21 checks passed
@tswast tswast deleted the tswast-bigquery-magics branch July 10, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update google-cloud-bigquery to use bigquery_magics package
3 participants