Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Directed Reads #1000

Merged
merged 26 commits into from
Jan 9, 2024
Merged

feat: Add support for Directed Reads #1000

merged 26 commits into from
Jan 9, 2024

Conversation

asthamohta
Copy link
Contributor

@asthamohta asthamohta commented Aug 10, 2023 •
edited by harshachinta
Loading

This PR adds code changes for Directed Reads feature.

@asthamohta asthamohta requested review from a team as code owners August 10, 2023 10:49
@snippet-bot
Copy link

snippet-bot bot commented Aug 10, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Aug 10, 2023
@harshachinta harshachinta changed the title feat: Direct reads changes feat: Directed reads changes Sep 30, 2023
harshachinta and others added 15 commits November 19, 2023 17:09
@harshachinta
Merge branch 'main' into direct-read-main-code
e6ae0de
@harshachinta
feat(spanner): remove client side validations for directed read options
3036bb6
@harshachinta
feat(spanner): update the auto_failover_disabled field
0e68229
@harshachinta
feat(spanner): update unit tests
dad4a2d
@harshachinta
feat(spanner): update test
c18e0a3
@harshachinta
Merge branch 'main' into direct-read-main-code
f06a7bc
@harshachinta
feat(spanner): update documentation
76cbdac
@harshachinta
feat(spanner): add system test to validate exception in case of RW tr…
71d728d 
…ansaction
@harshachinta
feat(spanner): update unit test
d349418
@harshachinta
Merge branch 'main' into direct-read-main-code
34026ca
@harshachinta
feat(spanner): add dro for batchsnapshot and update system tests
927da67
@harshachinta
feat(spanner): fix unit tests for batchsnapshot
2dfc406
@harshachinta
feat(spanner): add unit tests for partition read and query
f9af1d8
@harshachinta
Merge branch 'main' into direct-read-main-code
54a1e16
@harshachinta
Merge branch 'main' into direct-read-main-code
366f2f8
surbhigarg92
surbhigarg92 reviewed Dec 27, 2023
View reviewed changes
google/cloud/spanner_v1/_helpers.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/__init__.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/snapshot.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/snapshot.py Outdated Show resolved Hide resolved
surbhigarg92
surbhigarg92 reviewed Jan 8, 2024
View reviewed changes
google/cloud/spanner_v1/types/spanner.py Outdated Show resolved Hide resolved
tests/unit/test_database.py Show resolved Hide resolved
tests/unit/test_database.py Show resolved Hide resolved
@harshachinta harshachinta removed the request for review from kweinmeister January 8, 2024 12:18
@harshachinta harshachinta changed the title feat: Directed reads changes feat: Add support for Directed reads Jan 8, 2024
@harshachinta harshachinta changed the title feat: Add support for Directed reads feat: Add support for Directed Reads Jan 8, 2024
@harshachinta harshachinta merged commit c4210b2 into googleapis:main Jan 9, 2024
12 of 13 checks passed
@release-please release-please bot mentioned this pull request Jan 9, 2024
Merged
@harshachinta harshachinta mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshachinta harshachinta harshachinta left review comments

@surbhigarg92 surbhigarg92 surbhigarg92 approved these changes

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asthamohta @surbhigarg92 @harshachinta