Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: skip sample tests if no changes detected #1106

Merged
merged 3 commits into from
Mar 6, 2024
Merged

test: skip sample tests if no changes detected #1106

merged 3 commits into from
Mar 6, 2024

Conversation

rahul2393
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rahul2393 rahul2393 requested review from a team as code owners February 26, 2024 07:13
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: u Pull request is empty. and removed size: s Pull request size is small. labels Feb 26, 2024
@rahul2393 rahul2393 added the owlbot:ignore instruct owl-bot to ignore a PR label Feb 26, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: u Pull request is empty. labels Feb 26, 2024
@rahul2393 rahul2393 added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:ignore instruct owl-bot to ignore a PR labels Feb 26, 2024
@rahul2393 rahul2393 closed this Feb 26, 2024
@rahul2393 rahul2393 reopened this Feb 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 26, 2024
@rahul2393
Copy link
Contributor Author

@parthea Can we go ahead with this?

arpan14
arpan14 approved these changes Mar 4, 2024
View reviewed changes
Copy link

@arpan14 arpan14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please do verify after merging this change that we run these tests when the samples folder are modified. Want to make sure that we don't end up always skipping the tests.

@rahul2393 rahul2393 enabled auto-merge (squash) March 6, 2024 06:01
@rahul2393 rahul2393 merged commit 9c919fa into main Mar 6, 2024
14 of 16 checks passed
@rahul2393 rahul2393 deleted the optimize_sample_runs branch March 6, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arpan14 arpan14 arpan14 approved these changes

@parthea parthea Awaiting requested review from parthea

@harshachinta harshachinta Awaiting requested review from harshachinta

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahul2393 @arpan14