Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plural data source google_kms_crypto_keys #18605

Conversation

modular-magician
Copy link
Collaborator

This PR adds a new plural data source google_kms_crypto_keys.

Note: a weird part of this work is the need to explicitly add the id field to the schema for each individual key. The alternative would be to update the google_kms_crypto_key resource to have id in its schema (instead of implicitly added by the SDK) but this doesn't appear to be easily possible via MMv1.

Release Note Template for Downstream PRs (will be copied)

`google_kms_crypto_keys`

Derived from GoogleCloudPlatform/magic-modules#11053

[upstream:f514cc2e5b57129f3136b17ce602aa724fa390c4]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit 736aa48 into hashicorp:main Jun 28, 2024
2 checks passed
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant