Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisiting ProxyConfiguration.getProxies() #10086

Closed
cowwoc opened this issue Jul 9, 2023 · 0 comments · Fixed by #10116
Closed

Revisiting ProxyConfiguration.getProxies() #10086

cowwoc opened this issue Jul 9, 2023 · 0 comments · Fixed by #10116

Comments

@cowwoc
Copy link
Contributor

cowwoc commented Jul 9, 2023

@sbordet @joakime Revisiting #8723, I'm wondering whether it was wise/necessary to deprecate getProxies().

Maybe we could keep the getProxies() method but specify that it returns an unmodifiable List or Collection instead? This would restore the users' ability to look up the proxy list without exposing any implementation details. Users would still be forced to use the addProxy(), removeProxy() methods for mutation.

sbordet added a commit that referenced this issue Jul 17, 2023
Removed "for removal" deprecation, added clarifying javadocs.

Signed-off-by: Simone Bordet <[email protected]>
@sbordet sbordet linked a pull request Jul 17, 2023 that will close this issue
sbordet added a commit that referenced this issue Jul 17, 2023
Removed "for removal" deprecation, added clarifying javadocs.

Signed-off-by: Simone Bordet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant