Issue #9554 - move common hpack/qpack code to jetty-http #9628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
Signed-off-by: Lachlan Roberts <[email protected]>
gregw
requested changes
Apr 5, 2023
There was a problem hiding this comment.
So if I'm reading this right, h2 had a stateless Huffman class with encode and decode methods, but h3 separated those into a stateless HuffmanEncoder and a stateful HuffmanDecoder class, that uses the table in 'HuffmanEncoder`. Is that correct?
If so, I'd kind of prefer if we kept the stateless Huffman with the tables and static methods. Then introduce just a HuffmanDecoder class that does the stateful decoding. Perhaps use a Record to hold the state in the base class so it can be passed in by the stateful class
Signed-off-by: Lachlan Roberts <[email protected]>
|
@gregw I moved out the static huffman codes into a |
gregw
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #9554
move common hpack/qpack code to jetty-http