-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return 404 for non-existent queues for the visibility endpoints #1415
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @PBundyra. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @mimowo |
/ok-to-test |
25db658
to
cf00dad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @alculquicondor @tenzen-y
LGTM label has been added. Git tree hash: cfb13f64cd4ac3ef2a3ca62196e383f629e56799
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 24fce162bc514902824018c5f82e01e2a1b238d9
|
if err != nil && tc.wantErrMatch == nil { | ||
// An error was not expected but it appeared | ||
t.Error(err) | ||
} else if err != nil { | ||
// An error was expected and it appeared | ||
if !tc.wantErrMatch(err) { | ||
t.Errorf("Error differs: (-want,+got):\n%s", cmp.Diff(tc.wantResp.wantErr.Error(), err.Error())) | ||
} | ||
} else if tc.wantResp.wantErr != nil { | ||
// An error was expected but it didn't appear | ||
t.Errorf("Should have received an error: %v\n", tc.wantResp.wantErr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if tc.wantErrMatch != nil {
if !tc.wantErrMatch(err) { t.Error() }
} else if err != nil {
t.Error()
}
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, PBundyra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please squash
/hold cancel |
/lgtm |
LGTM label has been added. Git tree hash: 959e0594c49370170c9a2ab39cf507559b534a8f
|
/remove-kind bug |
/release-note-edit
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Method
cmpopts.EquateErrors()
returned diff due to different addresses of errors.Does this PR introduce a user-facing change?