-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): wrong webhooks indentation #2086
fix(helm): wrong webhooks indentation #2086
Conversation
Welcome @EladDolev! |
Hi @EladDolev. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EladDolev Thank you for creating this PR! Could you update this script as well?
Signed-off-by: Elad Dolev <[email protected]>
ee7ecbb
to
b5e01c7
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
/release-note-edit
HelmChart: Fix a bug that the `integrations.podOptions.namespaceSelector` is not propagated.
LGTM label has been added. Git tree hash: 543a55b0199f8ff065b5a11493b05bd8f61ff12e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EladDolev, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/release-note-edit
|
/cherry-pick release-0.6 |
@tenzen-y: once the present PR merges, I will cherry-pick it on top of release-0.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tenzen-y: new pull request created: #2095 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/release-note-edit
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
Without this commit anything under
integrations.podOptions.namespaceSelector:
just gets dropped by k8s api-serverDoes this PR introduce a user-facing change?