Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo to be GCE specific #2

Merged
merged 8 commits into from
Oct 6, 2017

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Oct 6, 2017

Please review commit-by-commit.

FYI: viewing the history of a moved file requires using git log --follow [file]. From what I've googled, Github does not use follow when showing commit history.

Todo in separate PR:

  • Migrate to dep instead of godep, remove unnecessary vendored dependencies at the same time.
  • Move main.go into a cmds/glbc dir.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 6, 2017
@nicksardo
Copy link
Contributor Author

Please review @bowei @thockin @nikhiljindal @csbell @freehan

@nicksardo
Copy link
Contributor Author

Received approval from @bowei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants