Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI config #2229

Merged
merged 3 commits into from
Aug 19, 2020
Merged

Fix CI config #2229

merged 3 commits into from
Aug 19, 2020

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Aug 10, 2020 •
edited
Loading

There were a number of problems with CI:

  • Headers are now capitalized vs. all lower-case which made one of the tests fail that was not able to read a header that was expected to be present
  • It seems there should be a default for the allow-failure flag (this did not cause the test failure but prevented the runner from handling the failure correctly)

@marcoow marcoow requested a review from a team August 10, 2020 10:27
@marcoow marcoow marked this pull request as ready for review August 10, 2020 10:32
@marcoow marcoow merged commit 3f7bc91 into master Aug 19, 2020
sdebarros pushed a commit that referenced this pull request Oct 16, 2020
@marcoow
Fix CI config (#2229)
4debca6 
* fix CI config

* fix capitatilazation of header

* set default for allow-failure
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdebarros sdebarros sdebarros approved these changes

@technightcoffee technightcoffee technightcoffee approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoow @sdebarros @technightcoffee