Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed quietly failing unit test because server returned nothing #2348

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

candunaj
Copy link
Contributor

@candunaj candunaj commented Dec 2, 2021

Issue

I have fixed quietly failing unit test.

Explanation

In that unit test is a fake server with no response. It caused the test to "throw undefined", which is not caught by mocha. I have fixed the test by returning success.

return [200, { 'Content-Type': 'application/json' }, '{}'];

@marcoow marcoow merged commit 5d0f0f5 into master Dec 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the test-failing-quietly2 branch December 2, 2021 10:33
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants