Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pnpm #2570

Merged
merged 11 commits into from
Jun 26, 2023
Merged

Move to pnpm #2570

merged 11 commits into from
Jun 26, 2023

Conversation

BobrImperator
Copy link
Collaborator

@BobrImperator BobrImperator commented Jun 23, 2023

  • removes yarn and uses pnpm instead
  • adds @embroider/test-setup to all packages because of symlinked ember-try scenarios that attempt to use it.

Note:
ember-release scenario should start passing after #2565

Procfile.client Outdated Show resolved Hide resolved
Copy link
Member

@marcoow marcoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d suggest keeping Volta - that has beta pnpm support now

@BobrImperator
Copy link
Collaborator Author

BobrImperator commented Jun 26, 2023

@marcoow It'd seem that this volta issue is blocking volta-cli/action#121
Also CrowdStrike/ember-headless-table#184

It doesn't seem to me that the experimental support is worth the hassle of figuring it out.

@marcoow
Copy link
Member

marcoow commented Jun 26, 2023

We're using it in Gravity and (I think) it works quite well – https://github.com/mainmatter/gravity/blob/master/.github/workflows/ci.yml

@BobrImperator
Copy link
Collaborator Author

ember-lts-4.12 seems to be the only version failing and might be bugged, see emberjs/data#8609

@BobrImperator BobrImperator merged commit 6348fe3 into master Jun 26, 2023
30 of 36 checks passed
@BobrImperator BobrImperator deleted the move-to-pnpm branch June 26, 2023 10:00
@BobrImperator
Copy link
Collaborator Author

Merged since it seems like I've cleared out the concerns, I'd like to see if renovate works correctly and so we can merge new package versions without the need to manually maintain lock files in this PR anymore.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants