Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): move events to an internal session #2812

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

BobrImperator
Copy link
Collaborator

  • Moves authenticationSucceeded and invalidationSucceeded event documentation to the InternalSession instead, since it's the one that emits them.

As pointed out here, these events are still documented as members of ESA's SessionService while it actually only uses the internal session events.

Copy link

github-actions bot commented Sep 2, 2024

Some tests with 'continue-on-error: true' have failed:

  • test-app test:one ember-beta

  • test-esa test:one ember-beta

  • classic-test-app test:one ember-beta

  • test-esa test:one ember-canary

  • classic-test-app test:one ember-canary

    Created by continue-on-error-comment

Copy link

github-actions bot commented Sep 2, 2024

Some tests with 'continue-on-error: true' have failed:

  • test-app test:one ember-canary

Created by continue-on-error-comment

@BobrImperator BobrImperator merged commit ec66c81 into master Sep 9, 2024
39 of 42 checks passed
@BobrImperator BobrImperator deleted the remove-events-from-docs branch September 9, 2024 10:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant