Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: the datacoord gc should fast quitable #35057

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jul 29, 2024

issue: #35049
pr: #35050

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 29, 2024
Copy link
Contributor

mergify bot commented Jul 29, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 46.42857% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.15%. Comparing base (256817d) to head (e20f463).
Report is 1 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #35057      +/-   ##
==========================================
+ Coverage   83.14%   83.15%   +0.01%     
==========================================
  Files         852      852              
  Lines      107236   107249      +13     
==========================================
+ Hits        89160    89184      +24     
+ Misses      14753    14747       -6     
+ Partials     3323     3318       -5     
Files Coverage Δ
internal/datacoord/garbage_collector.go 86.44% <46.42%> (-3.89%) ⬇️

... and 15 files with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Jul 29, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 29, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jul 30, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 30, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Jul 30, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jul 30, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Aug 1, 2024
@sre-ci-robot sre-ci-robot merged commit 923278b into milvus-io:2.3 Aug 1, 2024
10 of 12 checks passed
@chyezh chyezh deleted the enhance_fast_quit_gc_2_3 branch August 1, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants