Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground: Fix NodePrototypes being available across load/save-cycles #28030

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

abc013
Copy link
Contributor

@abc013 abc013 commented Mar 30, 2024

Description

When using Node Prototypes and loading a new scene in the playground, the classes generated by the Node Prototypes don't get removed from the search menu, such that classes that existed in the last scene could be used in the new one.
Example: Open the Playground, you'll see the teapot scene:
image
Now, create a new scene and search for the "Teapot Scene":
image

This PR fixes that by removing the class properly when removing the Node Prototype.

@sunag sunag self-assigned this Apr 1, 2024
@mrdoob mrdoob added this to the r164 milestone Apr 5, 2024
@sunag sunag merged commit 7a87e22 into mrdoob:dev Apr 8, 2024
11 checks passed
@abc013 abc013 deleted the fixPlaygroundPrototypeMulticlassBug branch April 16, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants