Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Fix UI of geometry generators when undo/redo. #28610

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jun 10, 2024

Fixed #28605.

Description

The idea is to refresh the UI during geometryChanged event which is already triggered by the respective geometry command when changing parameters.

@Mugen87 Mugen87 added this to the r166 milestone Jun 10, 2024
@ycw
Copy link
Contributor

ycw commented Jun 10, 2024

LGTM, please merge it now :D. I'll patch the UIPoints on top of this PR:

UIPoints.honor.undo.redo.mp4

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jun 10, 2024

@ycw Thanks! I have left out the points UI on purpose so we can focus on it separately. I'm curious to see your PR about UIPoints 👍 !

@Mugen87 Mugen87 merged commit 5858ca3 into mrdoob:dev Jun 10, 2024
10 of 11 checks passed
@ycw
Copy link
Contributor

ycw commented Jun 10, 2024

Thanks. #28611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor: Geometry parameters in GEOMETRY tab do not get refresh when UNDO/REDO
2 participants