Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Override alpha channel to 1 for opaque materials #28646

Merged

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #28645

Fix #28645. Respect the WebGLRenderer by overriding the diffuse alpha channel to 1 for opaque materials.

This contribution is funded by Utsubo

@0b5vr
Copy link
Collaborator

0b5vr commented Jun 13, 2024

According to the current code of WebGLPrograms, the OPAQUE flag also needs material.blending === NormalBlending and material.alphaToCoverage === false, I'm not sure how it affects though.

@RenaudRohlinger
Copy link
Collaborator Author

Nice catch @0b5vr! I updated the PR accordingly.

@RenaudRohlinger RenaudRohlinger merged commit 6c8ff24 into mrdoob:dev Jun 13, 2024
11 checks passed
0b5vr added a commit to pixiv/three-vrm that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeMaterial: Alpha channel behaves wrong on non-transparent materials
3 participants