Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the usage of makeStyles #7363

Closed
adityatoshniwal opened this issue Apr 9, 2024 · 11 comments
Closed

Remove the usage of makeStyles #7363

adityatoshniwal opened this issue Apr 9, 2024 · 11 comments

Comments

@adityatoshniwal
Copy link
Contributor

The @mui/styles package is deprecated from React 18 - https://mui.com/system/styles/basics/
Use - https://mui.com/material-ui/customization/how-to-customize/#2-reusable-component.

@yogeshmahajan-1903 yogeshmahajan-1903 self-assigned this Apr 18, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 17, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 17, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 17, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 20, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 20, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 20, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 20, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 20, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 20, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 21, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 21, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 22, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 22, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 22, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 22, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 30, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 31, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 31, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue May 31, 2024
@adityatoshniwal
Copy link
Contributor Author

Found few ui issues:
Pasted Graphic

Pasted Graphic 1 § PostgreSQL 12

@adityatoshniwal
Copy link
Contributor Author

Shortcuts should be on the right. Please check prev styling.
Image

yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue Jun 12, 2024
@pravesh-sharma
Copy link
Contributor

pravesh-sharma commented Jun 12, 2024

Run the explain/analyze query and move to the explain tab, headers are being shown as buttons.

Screenshot 2024-06-06 at 12 06 18 PM

@adityatoshniwal
Copy link
Contributor Author

Footer should stick to bottom.

Image

@anilsahoo20
Copy link
Contributor

Query history right side query box must take 100% width.
Screenshot 2024-06-12 at 6 35 39 PM

@yogeshmahajan-1903
Copy link
Contributor

Found few ui issues: Pasted Graphic

Not able to reproduce. Tried with docker snapshot also.

Pasted Graphic 1

Partially fixed. Left border around add icon still present. Regression due to react table changes.

§ PostgreSQL 12

Fixed.

@yogeshmahajan-1903
Copy link
Contributor

Shortcuts should be on the right. Please check prev styling. Image

Fixed.

@yogeshmahajan-1903
Copy link
Contributor

Run the explain/analyze query and move to the explain tab, headers are being shown as buttons.

Screenshot 2024-06-06 at 12 06 18 PM

Fixed.

@yogeshmahajan-1903
Copy link
Contributor

Query history right side query box must take 100% width. Screenshot 2024-06-12 at 6 35 39 PM

Fixed.

@adityatoshniwal
Copy link
Contributor Author

Not able to reproduce. Tried with docker snapshot also.

Try using dark theme on your MacOS.

@yogeshmahajan-1903
Copy link
Contributor

Not able to reproduce. Tried with docker snapshot also.

Try using dark theme on your MacOS.

I guess this is fixed with one of the above fix.

adityatoshniwal pushed a commit that referenced this issue Jun 19, 2024
yogeshmahajan-1903 added a commit to yogeshmahajan-1903/pgadmin4 that referenced this issue Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants