Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema Diff: Generate script button remains enabled even if not object is selected. #7638

Closed
pravesh-sharma opened this issue Jun 27, 2024 · 1 comment
Closed

Schema Diff: Generate script button remains enabled even if not object is selected. #7638

pravesh-sharma opened this issue Jun 27, 2024 · 1 comment
Assignees
@yogeshmahajan-1903
Labels
Bug EDB Sprint 172
Milestone
8.10

Comments

@pravesh-sharma
Copy link
Contributor

To Reproduce

Steps to reproduce the behavior:

  1. Open schema diff and compare two DBs or schemas
  2. Click on the check box to select any object, generate script button gets enabled.
  3. Change schema or click on the compare button again, generate script is still enabled however no object is selected

Expected behavior
The generate script button should be disabled.

Desktop (please complete the following information):

  • OS: macOS Sonoma 14.5
  • Version: 8.9
  • Mode: Desktop
@RohitBhati8269 RohitBhati8269 self-assigned this Jul 4, 2024
RohitBhati8269 added a commit to RohitBhati8269/pgadmin4 that referenced this issue Jul 4, 2024
@RohitBhati8269
fix disable GenerateScript button when no objects are selected in sch…
33b9b00 
…ema diff. pgadmin-org#7638
@RohitBhati8269 RohitBhati8269 mentioned this issue Jul 4, 2024
Merged
RohitBhati8269 added a commit to RohitBhati8269/pgadmin4 that referenced this issue Jul 9, 2024
@RohitBhati8269
Fix disable GenerateScript button when no objects are selected in sch…
c0b05a2 
…ema diff. pgadmin-org#7638
adityatoshniwal pushed a commit that referenced this issue Jul 9, 2024
@RohitBhati8269
Fixed an issue where Generate Script button should be disabled if no …
721a5da 
…objects are selected in the schema diff result. #7638
@adityatoshniwal adityatoshniwal added this to the 8.10 milestone Jul 9, 2024
@yogeshmahajan-1903 yogeshmahajan-1903 self-assigned this Jul 10, 2024
@yogeshmahajan-1903
Copy link
Contributor

Working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yogeshmahajan-1903 yogeshmahajan-1903

Labels
Bug EDB Sprint 172
Projects
None yet
Milestone
8.10
Development

No branches or pull requests
5 participants
@akshay-joshi @yogeshmahajan-1903 @adityatoshniwal @pravesh-sharma @RohitBhati8269