Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HttpGoneException executable flag #3278

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Remove HttpGoneException executable flag #3278

merged 1 commit into from
Aug 16, 2023

Conversation

flavioheleno
Copy link
Contributor

This PR performs a simple chmod -x on Slim/Exception/HttpGoneException.php as it was the only file in Slim's source to have the executable flag and I could not see a reason why it should have.

In other words, Slim/Exception/HttpGoneException.php permission flags went from 0755 to 0644.

@l0gicgate
Copy link
Member

Thank you for this contribution @flavioheleno

@coveralls
Copy link

Coverage Status

coverage: 99.427%. remained the same when pulling 5edfd79 on flavioheleno:patch-2 into e9e99c2 on slimphp:4.x.

@l0gicgate l0gicgate added this to the 4.13.0 milestone Aug 16, 2023
@l0gicgate l0gicgate merged commit 7ed49f1 into slimphp:4.x Aug 16, 2023
5 checks passed
@flavioheleno flavioheleno deleted the patch-2 branch August 16, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@flavioheleno @l0gicgate @coveralls