Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vanta.globe.js to use THREE.BufferGeometry #143

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Update vanta.globe.js to use THREE.BufferGeometry #143

merged 1 commit into from
Sep 16, 2022

Conversation

OmnesPotens
Copy link
Contributor

Fixes #142

@OmnesPotens OmnesPotens mentioned this pull request Aug 25, 2022
Merged
tengbao
tengbao approved these changes Sep 16, 2022
View reviewed changes
Copy link
Owner

@tengbao tengbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tengbao tengbao merged commit 10beb04 into tengbao:master Sep 16, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengbao tengbao tengbao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Globe needs to be updated to use new BufferGeometry to support three.js r125+
2 participants
@OmnesPotens @tengbao