Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starlette update breaks routing #10

Closed
medecau opened this issue Jan 23, 2019 · 2 comments · Fixed by #17
Closed

starlette update breaks routing #10

medecau opened this issue Jan 23, 2019 · 2 comments · Fixed by #17
Labels
bug Something isn't working reviewed

Comments

@medecau
Copy link

medecau commented Jan 23, 2019

starlette 0.9.11 breaks fastapi routing
I'm currently working around this by enforcing starlette==0.9.10
@tiangolo
Copy link
Member

Thanks for the report! I'll check it as soon as I get to my laptop.

@tiangolo tiangolo mentioned this issue Jan 23, 2019
Merged
@tiangolo
Copy link
Member

It should now be fixed in the latest version 0.1.18. The change is only pinning the dependencies so FastAPI is not broken, it should work now.

The next step will be to actually update FastAPI's code to be compatible with the latest changes in Starlette.

@euri10 euri10 mentioned this issue Jan 30, 2019
Merged
@tiangolo tiangolo added bug Something isn't working reviewed labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Starlette up version
2 participants
@medecau @tiangolo