📝 Fix inconsistent response code when item already exists in docs for testing #11818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #4482, the response status code was changed to return 409 when the item already exists in non-Annotated examples, but left as 400 in the others. Seems like an oversight, unless this was done intentionally for a reason I'm not aware of.
|
📝 Docs preview for commit f3c1a2d at: https://7d76d610.fastapitiangolo.pages.dev |
GDemay
approved these changes
Jul 12, 2024
Kludex
approved these changes
Jul 13, 2024
|
Good catch, thank you @lokomilo! 🔍 🚀 |
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Aug 16, 2024
… testing (fastapi#11818) Co-authored-by: Sebastián Ramírez <[email protected]>
black-redoc
pushed a commit
to black-redoc/fastapi
that referenced
this pull request
Aug 17, 2024
… testing (fastapi#11818) Co-authored-by: Sebastián Ramírez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #4482, the response status code was changed to return 409 when the item already exists in non-Annotated examples, but it is 400 in the other examples created after that PR.