Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cn translation for serveral sections of advanced user guide. #1804

Closed
wants to merge 15 commits into from

Conversation

woostundy
Copy link

including:

index.md
path-operation-advanced-configuration.md
additional-status-codes.md
custom-response.md
response-directly.md

And more will be added later.

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1804 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1804    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          238       235     -3     
  Lines         7187      6989   -198     
==========================================
- Hits          7187      6989   -198     
Impacted Files Coverage Δ
fastapi/dependencies/utils.py 100.00% <0.00%> (ø)
tests/main.py
tests/utils.py
fastapi/utils.py
fastapi/__init__.py
tests/test_get_request_body.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60dd1b...5145550. Read the comment docs.

@github-actions
Copy link
Contributor

@tiangolo
Copy link
Member

tiangolo commented Aug 3, 2020

That's great! 🎉

Could you separate each file in a different PR?

If each file is in a different PR, it will be easier for others to review an entire PR and/or add comments to specific sections.

@tiangolo tiangolo added lang-zh Chinese translations awaiting-review lang-all Translations labels Aug 3, 2020
@waynerv
Copy link
Contributor

waynerv commented Aug 5, 2020

The embarrassing thing is these 5 articles have already been translated by @RunningIkkyu . you should follow the contribution guide and check PR list to avoid duplicate work.

@woostundy
Copy link
Author

The embarrassing thing is these 5 articles have already been translated by @RunningIkkyu . you should follow the contribution guide and check PR list to avoid duplicate work.

It's my fault that I forgot to check.
But I find there are three sections translated in PR list: #1447 #1451 #1452 if I haven't miss others.
So should I create new PRs for index.md and custom-response.md ?

@RunningIkkyu
Copy link
Contributor

#1445 #1451 #1447 #1452 #1459 @woostundy Please review these files.

@waynerv
Copy link
Contributor

waynerv commented Aug 6, 2020

Filtering PR list by label lang-zh and you will see all the Chinese translations.

@maoyibo maoyibo mentioned this pull request Nov 25, 2020
@tiangolo
Copy link
Member

As these translations have been added in other PRs I'm gonna close this one. Thanks! ☕

@tiangolo tiangolo closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-zh Chinese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants