Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Add Chinese translation for Benchmarks #2119

Merged
merged 2 commits into from
Nov 25, 2020
Merged

Conversation

spaceack
Copy link
Contributor

@spaceack spaceack commented Oct 2, 2020

This PR translates the benchmarks.md to Chinese.
Please help review. @waynerv @Dustyposa @RunningIkkyu @Choyeon

@codecov
Copy link

codecov bot commented Oct 2, 2020

Codecov Report

Merging #2119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2119   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          239       239           
  Lines         7079      7079           
=========================================
  Hits          7079      7079           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77ea63...0b50af6. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2020

docs/zh/docs/benchmarks.md Outdated Show resolved Hide resolved

独立公司 TechEmpower 的基准测试表明在 Uvicorn 下运行的 **FastAPI** 应用程序是 <a href="https://www.techempower.com/benchmarks/#section=test&runid=7464e520-0dc2-473d-bd34-dbdfd7e85911&hw=ph&test=query&l=zijzen-7" class="external-link" target="_blank">可用的最快的 Python 框架之一</a>,仅次与 Starlette 和 Uvicorn 本身 (由 FastAPI 内部使用)。(*)

但是在检查基准测试或与其它同类比较时,请注意以下几点。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"checking benchmarks and comparisons" should be "查看基准得分和对比"


## 基准测试和速度

当您做基准测试检查时,通常会看到被视为等效的几种不同类型的工具。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

当你查看基准测试时,几个不同类型的工具被等效地做比较是很常见的情况。


* **Uvicorn**:
* 具有最佳性能,因为除了服务器本身外,它没有太多额外的代码。
* 您不会直接在 Uvicorn 中编写应用程序。这意味着您的代码至少必须包含 Starlette(或 **FastAPI**)提供的代码。如果您这样做了,最终应用程序和框架会最大程度地减少应用程序代码的编码量和错误。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

”And if you did that, your final application would have the same overhead as having used a framework and minimizing your app code and bugs.“ means "如果你这样做了(即直接在 Uvicorn 中编写应用程序),你最终的应用程序会和使用了框架并且最小化了应用代码和 bug 的情况具有相同的性能损耗。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review

docs/zh/docs/benchmarks.md Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2020

Copy link
Contributor

@waynerv waynerv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maoyibo maoyibo mentioned this pull request Nov 25, 2020
@tiangolo tiangolo changed the title Add Chinese translation for benchmarks.md 🌐 Add Chinese translation for Benchmarks Nov 25, 2020
@tiangolo
Copy link
Member

Great! Thank you @spaceack 🙇 🚀

And thanks @waynerv and @Laineyzhang55 for the reviews 👏 👏 ☕

@tiangolo tiangolo merged commit 2434980 into fastapi:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants