Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Update Optional usage in Chinese translation for Python Types Intro docs/zh/docs/python-types.md #2360

Closed
wants to merge 2 commits into from

Conversation

maoyibo
Copy link
Contributor

@maoyibo maoyibo commented Nov 17, 2020

Add Generic types with type parameters and Generic types, Fix the code file name of Optional and subsequent chapters.

Add `Generic types with type parameters` and `Generic types`, Fix the code file name of `Optional` and subsequent chapters.
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #2360 (6f00984) into master (7d7289a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          240       240           
  Lines         7101      7101           
=========================================
  Hits          7101      7101           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b53c443...6f00984. Read the comment docs.

@github-actions
Copy link
Contributor

@maoyibo maoyibo changed the title Add Generic types Fix Optional chinese translate python-types.md Add Generic types Fix Optional Nov 17, 2020
@maoyibo maoyibo mentioned this pull request Nov 17, 2020
docs/zh/docs/python-types.md Outdated Show resolved Hide resolved
* `Set`
* `Dict`
* `Optional`
* ...and others.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...及其他。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, Thanks.

@github-actions
Copy link
Contributor

@tiangolo tiangolo changed the title chinese translate python-types.md Add Generic types Fix Optional 🌐 Update Optional usage in Chinese translation for Python Types Intro Nov 25, 2020
@tiangolo tiangolo added awaiting-review lang-all Translations lang-zh Chinese translations labels Nov 25, 2020
@tiangolo tiangolo changed the title 🌐 Update Optional usage in Chinese translation for Python Types Intro 🌐 Update Optional usage in Chinese translation for Python Types Intro docs/zh/docs/python-types.md Jun 26, 2023
@tiangolo
Copy link
Member

As this is an update and @waynerv, who's one of the champions of Chinese, already approved, I'll merge this right away. 🤓

Thanks @maoyibo! ☕

@tiangolo tiangolo enabled auto-merge (squash) January 12, 2024 13:31
@tiangolo
Copy link
Member

Hum, as the branch was removed, I can't update this PR to see if there are any new changes, so I'll have to close it and wait for some new PR with the same (or other) changes. 😅

@tiangolo tiangolo closed this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review lang-all Translations lang-zh Chinese translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants