Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Chinese translation for Tutorial - Extra Models #2416

Merged
merged 3 commits into from
Dec 3, 2020
Merged

🌐 Add Chinese translation for Tutorial - Extra Models #2416

merged 3 commits into from
Dec 3, 2020

Conversation

waynerv
Copy link
Contributor

@waynerv waynerv commented Nov 25, 2020

@maoyibo @Dustyposa @RunningIkkyu Please take a look.

@codecov
Copy link

codecov bot commented Nov 25, 2020 •
edited

Codecov Report

Merging #2416 (3f472db) into master (478f157) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2416   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          242       242           
  Lines         7396      7396           
=========================================
  Hits          7396      7396

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1ca8da...3f472db. Read the comment docs.

@waynerv waynerv mentioned this pull request Nov 25, 2020
Closed
@github-actions
Copy link
Contributor

📝 Docs preview for commit 41e43ab at: https://5fbe3a7cae4a4f47e87df668--fastapi.netlify.app

@tiangolo tiangolo changed the title Add chinese translation for tutorial/extra-models.md 🌐 Add Chinese translation for Tutorial - Extra Models Nov 25, 2020
@tiangolo tiangolo added awaiting-review lang-all Translations lang-zh Chinese translations labels Nov 25, 2020
maoyibo
maoyibo reviewed Nov 26, 2020
View reviewed changes
Copy link
Contributor

@maoyibo maoyibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks pretty good.

docs/zh/docs/tutorial/extra-models.md
user_dict = user_in.dict()
```

现在我们有了一个数据位于变量 `user_dict` 中的 `dict`（它是一个 `dict` 而不是 Pydantic 模型对象）。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在我们有了一个包含 user_dict 变量中数据的 dict

@github-actions
Copy link
Contributor

📝 Docs preview for commit ed43502 at: https://5fbf35c4613244e55df9663a--fastapi.netlify.app

maoyibo
maoyibo reviewed Nov 26, 2020
View reviewed changes
Copy link
Contributor

@maoyibo maoyibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@tiangolo
Copy link
Member

tiangolo commented Dec 3, 2020

Awesome! Thank you @waynerv 🙇 🚀

And thanks for the reviews @maoyibo , @yanever , @Laineyzhang55 🍰 ☕

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

📝 Docs preview for commit 3f472db at: https://5fc9215cb7bb7d2494991818--fastapi.netlify.app

@tiangolo tiangolo merged commit f175929 into fastapi:master Dec 3, 2020
@waynerv waynerv deleted the add-chinese-translation-for-extra-model.md branch January 13, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maoyibo maoyibo maoyibo approved these changes

@yanever yanever yanever approved these changes

@Laineyzhang55 Laineyzhang55 Laineyzhang55 approved these changes

Assignees
No one assigned
Labels
approved-2 lang-all Translations lang-zh Chinese translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@waynerv @tiangolo @maoyibo @yanever @Laineyzhang55