Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-view-transitions-1] Handling cases where transition constraints are broken mid transition #7882

Closed
khushalsagar opened this issue Oct 13, 2022 · 9 comments · Fixed by #8540

Comments

@khushalsagar
Copy link
Member

View transitions require a bunch of constraints to be satisfied by tagged elements listed here:

If any of the following is true:

usedTransitionTags [contains](https://infra.spec.whatwg.org/#list-contain) transitionTag.

element is not element’s [root](https://dom.spec.whatwg.org/#concept-tree-root) and element does not have [layout containment](https://drafts.csswg.org/css-contain-2/#layout-containment).

element is not element’s [root](https://dom.spec.whatwg.org/#concept-tree-root) and element allows [fragmentation](https://drafts.csswg.org/css-break-4/#fragmentation).

This state can also change mid transition. The simplest thing is to skip the transition in this case.

@khushalsagar khushalsagar added the css-view-transitions-1 View Transitions; Bugs only label Oct 13, 2022
@khushalsagar
Copy link
Member Author

khushalsagar commented Oct 18, 2022

Summary from offline discussion: It makes sense to abort the transition if per element constraints are broken, i.e., no layout containment or the element allows fragmentation. But detecting if the computed value of tags on all DOM elements has changed (so we now have duplicate tags etc.) adds more computation work. And that work would be to detect a developer bug and abort the transition. So not worth it.

Proposed Resolution: If constraints on elements participating in a transition become unsatisfied after a transition is running, the transition is aborted. Set of tagged elements participating in a transition is not re-computed after animations have started.

@atanassov atanassov added this to View transitions in October 26 meeting Oct 25, 2022
@astearns astearns moved this from View transitions to Overflow items in October 26 meeting Oct 26, 2022
@khushalsagar
Copy link
Member Author

One constraint (which I missed above) is that an element participating in a transition must generate a box (can't be display: none).

When walking through the DOM to identify named elements, we ignore DOM elements which don't generate a box (as if they had view-transition-name:none). See spec text here: "If transitionName is none, or element is not rendered, then continue."

A change in this state (such that the element no longer generates a box) should also skip the transition.

@atanassov atanassov added this to Agenda+ in November 30 2022 Nov 16, 2022
@jakearchibald
Copy link
Contributor

Another option for an element changing to display: none (or being removed from the DOM):

If there's a ::view-transition-old: Remove the ::view-transition-new from that pair, and set the end position & size to the captured element's position & size. This means the animation would continue as if there was no captured element in the new state.

If there isn't a ::view-transition-old: Remove the ::view-transition-group.

If the element is reshown during the transition: Do nothing. It can't come back.

@fantasai
Copy link
Collaborator

fantasai commented Dec 6, 2022

@jakearchibald @khushalsagar Can you summarize what question you want to ask the WG? It's okay to have multiple options to consider (or even an open-ended question), but since there's been several threads of conversation I just want us collect in one comment everything we want the CSSWG to consider. :)

@fantasai fantasai added this to By Theme in Agenda Scratchpad Dec 6, 2022
@fantasai fantasai moved this from By Theme to i18n in Agenda Scratchpad Dec 6, 2022
@fantasai fantasai moved this from i18n to Needs Editor Followup in Agenda Scratchpad Dec 6, 2022
@jakearchibald
Copy link
Contributor

jakearchibald commented Dec 6, 2022

In a transition group that has a 'new' component (as in, the end state of the transition is linked to a renderable element in the document), that element controls the final width/height/position of the ::view-transition-group and the natural size and image of the ::view-transition-new.

If that element changes layout or appearance, the ::view-transition-group and ::view-transition-new is updated.

But, what should happen if, mid-transition:

  • That element is no longer renderable (eg display: none or removed from the document)
  • That element becomes renderable again

And does the behaviour change depending on if the ::view-transition-group has a ::view-transition-old (as in, it's transitioning 'from' a captured element)?

The following options assume that the linking of source elements to ::view-transition-new via their view-transition-name is performed once. As in, changes to elements' view-transition-name do not impact the current transition.

It also assumes that "the element is no longer renderable" check is performed in the render steps, when the view transition currently updates its state per frame.


Option 1: Skip the transition

If the transition starts with a ::view-transition-new, then it's required that the source element is capturable until the end of the transition. Otherwise, the remainder of the transition is skipped.

Option 2: Adapt the transition, no backsies

If the element is no longer renderable:

If the group has a ::view-transition-old, then the group's associated ::view-transition-new is removed from the group. The size & transform of the ::view-transition-group becomes the same as its 'from' keyframe (meaning it stays in the same size and position as the old element).

This puts the ::view-transition-group into a state as if the ::view-transition-new wasn't there in the first place.

However, this would cause ::view-transition-old:only-child to match, and which could cause new animations to start mid-way through the transition.

If the group does not have a ::view-transition-old, then the ::view-transition-group is removed.

If the element becomes renderable again, no action is taken.

Option 3: Adapt the transition, with backsies

If the element is no longer renderable, the group's associated ::view-transition-new becomes 0x0, transparent.

If the group has a ::view-transition-old, the size & transform of the ::view-transition-group becomes the same as its 'from' keyframe (meaning it stays in the same size and position as the old element).

This is mostly as if ::view-transition-new wasn't there in the first place, but not quite.

If the group does not have a ::view-transition-old, the size & transform of the ::view-transition-group becomes 0x0, with no transform (placing the group in the top-left of the snapshot viewport).

If the element becomes renderable again, the state is updated again, allowing the element to reappear.


The two "adapt the transition" options seem to have weird trade-offs, so I think I'm happiest with option 1.

@khushalsagar
Copy link
Member Author

Thanks for the summary @jakearchibald. +1 to option 1. Toggling of this state mid-transition seems like a bug rather than a pattern the developer would need for a particular UX.

@khushalsagar
Copy link
Member Author

Reiterating the proposed resolution : "If constraints on new elements participating in a transition become unsatisfied mid-transition, the transition is aborted."

Note that this issue is limited to the behaviour if the constraints are changed by the developer during the transition. The exact constraints are already in the spec with active discussion on clarifying/relaxing them:

@astearns
Copy link
Member

Since there is a clear resolution and agreement here in the issue, let’s try making this an async resolution.

The CSSWG will automatically accept this resolution one week from now if no objections are raised here. Anyone can add an emoji to this comment to express support. If you do not support this resolution, please add a new comment.

proposed resolution : If constraints on new elements participating in a transition become unsatisfied mid-transition, the transition is aborted.

@astearns astearns added Async Resolution: Proposed Candidate for auto-resolve with stated time limit and removed Agenda+ labels Jan 24, 2023
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 24, 2023
This patch removes the containment requirement from view-transitions.

This is to align with proposed resolution
 w3c/csswg-drafts#7882

[email protected], [email protected]

Fixed: 1409491
Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
aarongable pushed a commit to chromium/chromium that referenced this issue Jan 24, 2023
This patch removes the containment requirement from view-transitions.

This is to align with proposed resolution
 w3c/csswg-drafts#7882

[email protected], [email protected]

Fixed: 1409491
Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096187}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 24, 2023
This patch removes the containment requirement from view-transitions.

This is to align with proposed resolution
 w3c/csswg-drafts#7882

[email protected], [email protected]

Fixed: 1409491
Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096187}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 24, 2023
This patch removes the containment requirement from view-transitions.

This is to align with proposed resolution
 w3c/csswg-drafts#7882

[email protected], [email protected]

Fixed: 1409491
Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096187}
aarongable pushed a commit to chromium/chromium that referenced this issue Jan 24, 2023
This reverts commit e554cf3.

Reason for revert: Decided against this feature for now.

Original change's description:
> VT: Remove containment requirement.
>
> This patch removes the containment requirement from view-transitions.
>
> This is to align with proposed resolution
>  w3c/csswg-drafts#7882
>
> R=​[email protected], [email protected]
>
> Fixed: 1409491
> Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> Reviewed-by: David Bokan <[email protected]>
> Reviewed-by: Khushal Sagar <[email protected]>
> Commit-Queue: Vladimir Levin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096187}

Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
Commit-Queue: Vladimir Levin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096273}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 24, 2023
This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.

Reason for revert: Decided against this feature for now.

Original change's description:
> VT: Remove containment requirement.
>
> This patch removes the containment requirement from view-transitions.
>
> This is to align with proposed resolution
>  w3c/csswg-drafts#7882
>
> R=​[email protected], [email protected]
>
> Fixed: 1409491
> Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> Reviewed-by: David Bokan <[email protected]>
> Reviewed-by: Khushal Sagar <[email protected]>
> Commit-Queue: Vladimir Levin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096187}

Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
Commit-Queue: Vladimir Levin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096273}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Jan 24, 2023
This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.

Reason for revert: Decided against this feature for now.

Original change's description:
> VT: Remove containment requirement.
>
> This patch removes the containment requirement from view-transitions.
>
> This is to align with proposed resolution
>  w3c/csswg-drafts#7882
>
> R=​[email protected], [email protected]
>
> Fixed: 1409491
> Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> Reviewed-by: David Bokan <[email protected]>
> Reviewed-by: Khushal Sagar <[email protected]>
> Commit-Queue: Vladimir Levin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096187}

Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
Commit-Queue: Vladimir Levin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096273}
@astearns
Copy link
Member

RESOLVED : If constraints on new elements participating in a transition become unsatisfied mid-transition, the transition is aborted.

@astearns astearns added Needs Edits and removed Async Resolution: Proposed Candidate for auto-resolve with stated time limit labels Jan 31, 2023
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 1, 2023
…estonly

Automatic update from web-platform-tests
VT: Remove containment requirement.

This patch removes the containment requirement from view-transitions.

This is to align with proposed resolution
 w3c/csswg-drafts#7882

[email protected], [email protected]

Fixed: 1409491
Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096187}

--

wpt-commits: d472d427d182823de6e8bc7e629e58a605c45d7c
wpt-pr: 38128
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 1, 2023
…nt.", a=testonly

Automatic update from web-platform-tests
Revert "VT: Remove containment requirement."

This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.

Reason for revert: Decided against this feature for now.

Original change's description:
> VT: Remove containment requirement.
>
> This patch removes the containment requirement from view-transitions.
>
> This is to align with proposed resolution
>  w3c/csswg-drafts#7882
>
> R=​[email protected], [email protected]
>
> Fixed: 1409491
> Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> Reviewed-by: David Bokan <[email protected]>
> Reviewed-by: Khushal Sagar <[email protected]>
> Commit-Queue: Vladimir Levin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096187}

Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
Commit-Queue: Vladimir Levin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096273}

--

wpt-commits: 404735f5905970d19b54fc1c4e9f84ef19edaac3
wpt-pr: 38144
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Feb 3, 2023
…estonly

Automatic update from web-platform-tests
VT: Remove containment requirement.

This patch removes the containment requirement from view-transitions.

This is to align with proposed resolution
 w3c/csswg-drafts#7882

[email protected], [email protected]

Fixed: 1409491
Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096187}

--

wpt-commits: d472d427d182823de6e8bc7e629e58a605c45d7c
wpt-pr: 38128
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Feb 3, 2023
…nt.", a=testonly

Automatic update from web-platform-tests
Revert "VT: Remove containment requirement."

This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.

Reason for revert: Decided against this feature for now.

Original change's description:
> VT: Remove containment requirement.
>
> This patch removes the containment requirement from view-transitions.
>
> This is to align with proposed resolution
>  w3c/csswg-drafts#7882
>
> R=​[email protected], [email protected]
>
> Fixed: 1409491
> Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> Reviewed-by: David Bokan <[email protected]>
> Reviewed-by: Khushal Sagar <[email protected]>
> Commit-Queue: Vladimir Levin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096187}

Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
Commit-Queue: Vladimir Levin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096273}

--

wpt-commits: 404735f5905970d19b54fc1c4e9f84ef19edaac3
wpt-pr: 38144
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Feb 8, 2023
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

w3c/csswg-drafts#8139

Original change's description:
> Revert "VT: Remove containment requirement."
>
> This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.
>
> Reason for revert: Decided against this feature for now.
>
> Original change's description:
> > VT: Remove containment requirement.
> >
> > This patch removes the containment requirement from view-transitions.
> >
> > This is to align with proposed resolution
> >  w3c/csswg-drafts#7882
> >
> > R=​[email protected], [email protected]
> >
> > Fixed: 1409491
> > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> > Reviewed-by: David Bokan <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Commit-Queue: Vladimir Levin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1096187}
>
> Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
> Commit-Queue: Vladimir Levin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096273}

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
aarongable pushed a commit to chromium/chromium that referenced this issue Feb 8, 2023
This reverts commit f2820f7.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

w3c/csswg-drafts#8139

Original change's description:
> Revert "VT: Remove containment requirement."
>
> This reverts commit e554cf3.
>
> Reason for revert: Decided against this feature for now.
>
> Original change's description:
> > VT: Remove containment requirement.
> >
> > This patch removes the containment requirement from view-transitions.
> >
> > This is to align with proposed resolution
> >  w3c/csswg-drafts#7882
> >
> > R=​[email protected], [email protected]
> >
> > Fixed: 1409491
> > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> > Reviewed-by: David Bokan <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Commit-Queue: Vladimir Levin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1096187}
>
> Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
> Commit-Queue: Vladimir Levin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096273}

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087
Commit-Queue: Vladimir Levin <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1102856}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Feb 8, 2023
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

w3c/csswg-drafts#8139

Original change's description:
> Revert "VT: Remove containment requirement."
>
> This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.
>
> Reason for revert: Decided against this feature for now.
>
> Original change's description:
> > VT: Remove containment requirement.
> >
> > This patch removes the containment requirement from view-transitions.
> >
> > This is to align with proposed resolution
> >  w3c/csswg-drafts#7882
> >
> > R=​[email protected], [email protected]
> >
> > Fixed: 1409491
> > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> > Reviewed-by: David Bokan <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Commit-Queue: Vladimir Levin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1096187}
>
> Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
> Commit-Queue: Vladimir Levin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096273}

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087
Commit-Queue: Vladimir Levin <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1102856}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this issue Feb 8, 2023
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

w3c/csswg-drafts#8139

Original change's description:
> Revert "VT: Remove containment requirement."
>
> This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.
>
> Reason for revert: Decided against this feature for now.
>
> Original change's description:
> > VT: Remove containment requirement.
> >
> > This patch removes the containment requirement from view-transitions.
> >
> > This is to align with proposed resolution
> >  w3c/csswg-drafts#7882
> >
> > R=​[email protected], [email protected]
> >
> > Fixed: 1409491
> > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> > Reviewed-by: David Bokan <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Commit-Queue: Vladimir Levin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1096187}
>
> Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
> Commit-Queue: Vladimir Levin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096273}

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087
Commit-Queue: Vladimir Levin <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1102856}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Feb 20, 2023
…nt.", a=testonly

Automatic update from web-platform-tests
Reland "VT: Remove containment requirement."

This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

w3c/csswg-drafts#8139

Original change's description:
> Revert "VT: Remove containment requirement."
>
> This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.
>
> Reason for revert: Decided against this feature for now.
>
> Original change's description:
> > VT: Remove containment requirement.
> >
> > This patch removes the containment requirement from view-transitions.
> >
> > This is to align with proposed resolution
> >  w3c/csswg-drafts#7882
> >
> > R=​[email protected], [email protected]
> >
> > Fixed: 1409491
> > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> > Reviewed-by: David Bokan <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Commit-Queue: Vladimir Levin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1096187}
>
> Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
> Commit-Queue: Vladimir Levin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096273}

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087
Commit-Queue: Vladimir Levin <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1102856}

--

wpt-commits: 8304fd86ce591ba34f172f46f5fadc017a4db814
wpt-pr: 38421
jamienicol pushed a commit to jamienicol/gecko that referenced this issue Feb 23, 2023
…nt.", a=testonly

Automatic update from web-platform-tests
Reland "VT: Remove containment requirement."

This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

w3c/csswg-drafts#8139

Original change's description:
> Revert "VT: Remove containment requirement."
>
> This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.
>
> Reason for revert: Decided against this feature for now.
>
> Original change's description:
> > VT: Remove containment requirement.
> >
> > This patch removes the containment requirement from view-transitions.
> >
> > This is to align with proposed resolution
> >  w3c/csswg-drafts#7882
> >
> > R=​[email protected], [email protected]
> >
> > Fixed: 1409491
> > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> > Reviewed-by: David Bokan <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Commit-Queue: Vladimir Levin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1096187}
>
> Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
> Commit-Queue: Vladimir Levin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096273}

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087
Commit-Queue: Vladimir Levin <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1102856}

--

wpt-commits: 8304fd86ce591ba34f172f46f5fadc017a4db814
wpt-pr: 38421
jakearchibald added a commit to jakearchibald/csswg-drafts that referenced this issue Mar 7, 2023
chirayudesai pushed a commit to chirayudesai/chromium that referenced this issue Mar 7, 2023
This reverts commit f2820f7.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

w3c/csswg-drafts#8139

Original change's description:
> Revert "VT: Remove containment requirement."
>
> This reverts commit e554cf3.
>
> Reason for revert: Decided against this feature for now.
>
> Original change's description:
> > VT: Remove containment requirement.
> >
> > This patch removes the containment requirement from view-transitions.
> >
> > This is to align with proposed resolution
> >  w3c/csswg-drafts#7882
> >
> > R=​[email protected], [email protected]
> >
> > Fixed: 1409491
> > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> > Reviewed-by: David Bokan <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Commit-Queue: Vladimir Levin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1096187}
>
> Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
> Commit-Queue: Vladimir Levin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096273}

(cherry picked from commit 652c5ff)

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087
Commit-Queue: Vladimir Levin <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Original-Commit-Position: refs/heads/main@{#1102856}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233792
Commit-Queue: Xianzhu Wang <[email protected]>
Reviewed-by: Xianzhu Wang <[email protected]>
Cr-Commit-Position: refs/branch-heads/5563@{#318}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this issue Mar 28, 2023
This patch removes the containment requirement from view-transitions.

This is to align with proposed resolution
 w3c/csswg-drafts#7882

[email protected], [email protected]

Fixed: 1409491
Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096187}
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this issue Mar 28, 2023
This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.

Reason for revert: Decided against this feature for now.

Original change's description:
> VT: Remove containment requirement.
>
> This patch removes the containment requirement from view-transitions.
>
> This is to align with proposed resolution
>  w3c/csswg-drafts#7882
>
> R=​[email protected], [email protected]
>
> Fixed: 1409491
> Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> Reviewed-by: David Bokan <[email protected]>
> Reviewed-by: Khushal Sagar <[email protected]>
> Commit-Queue: Vladimir Levin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096187}

Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
Commit-Queue: Vladimir Levin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096273}
marcoscaceres pushed a commit to web-platform-tests/wpt that referenced this issue Mar 28, 2023
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387.

This was reverted earlier to wait for CSSWG feedback. The resolution
aligns with the behaviour in this patch.

w3c/csswg-drafts#8139

Original change's description:
> Revert "VT: Remove containment requirement."
>
> This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.
>
> Reason for revert: Decided against this feature for now.
>
> Original change's description:
> > VT: Remove containment requirement.
> >
> > This patch removes the containment requirement from view-transitions.
> >
> > This is to align with proposed resolution
> >  w3c/csswg-drafts#7882
> >
> > R=​[email protected], [email protected]
> >
> > Fixed: 1409491
> > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> > Reviewed-by: David Bokan <[email protected]>
> > Reviewed-by: Khushal Sagar <[email protected]>
> > Commit-Queue: Vladimir Levin <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1096187}
>
> Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
> Commit-Queue: Vladimir Levin <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096273}

Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087
Commit-Queue: Vladimir Levin <[email protected]>
Commit-Queue: Khushal Sagar <[email protected]>
Auto-Submit: Khushal Sagar <[email protected]>
Reviewed-by: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1102856}
@fantasai fantasai removed this from Needs Editor Followup in Agenda Scratchpad Dec 13, 2023
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Jun 1, 2024
…estonly

Automatic update from web-platform-tests
VT: Remove containment requirement.

This patch removes the containment requirement from view-transitions.

This is to align with proposed resolution
 w3c/csswg-drafts#7882

[email protected], [email protected]

Fixed: 1409491
Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
Reviewed-by: David Bokan <[email protected]>
Reviewed-by: Khushal Sagar <[email protected]>
Commit-Queue: Vladimir Levin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096187}

--

wpt-commits: d472d427d182823de6e8bc7e629e58a605c45d7c
wpt-pr: 38128
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this issue Jun 1, 2024
…nt.", a=testonly

Automatic update from web-platform-tests
Revert "VT: Remove containment requirement."

This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd.

Reason for revert: Decided against this feature for now.

Original change's description:
> VT: Remove containment requirement.
>
> This patch removes the containment requirement from view-transitions.
>
> This is to align with proposed resolution
>  w3c/csswg-drafts#7882
>
> R=​[email protected], [email protected]
>
> Fixed: 1409491
> Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811
> Reviewed-by: David Bokan <[email protected]>
> Reviewed-by: Khushal Sagar <[email protected]>
> Commit-Queue: Vladimir Levin <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1096187}

Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788
Commit-Queue: Vladimir Levin <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1096273}

--

wpt-commits: 404735f5905970d19b54fc1c4e9f84ef19edaac3
wpt-pr: 38144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants