-
Notifications
You must be signed in to change notification settings - Fork 647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-view-transitions-1] Handling cases where transition constraints are broken mid transition #7882
Comments
Summary from offline discussion: It makes sense to abort the transition if per element constraints are broken, i.e., no layout containment or the element allows fragmentation. But detecting if the computed value of tags on all DOM elements has changed (so we now have duplicate tags etc.) adds more computation work. And that work would be to detect a developer bug and abort the transition. So not worth it. Proposed Resolution: If constraints on elements participating in a transition become unsatisfied after a transition is running, the transition is aborted. Set of tagged elements participating in a transition is not re-computed after animations have started. |
One constraint (which I missed above) is that an element participating in a transition must generate a box (can't be When walking through the DOM to identify named elements, we ignore DOM elements which don't generate a box (as if they had A change in this state (such that the element no longer generates a box) should also skip the transition. |
Another option for an element changing to If there's a If there isn't a If the element is reshown during the transition: Do nothing. It can't come back. |
@jakearchibald @khushalsagar Can you summarize what question you want to ask the WG? It's okay to have multiple options to consider (or even an open-ended question), but since there's been several threads of conversation I just want us collect in one comment everything we want the CSSWG to consider. :) |
In a transition group that has a 'new' component (as in, the end state of the transition is linked to a renderable element in the document), that element controls the final width/height/position of the If that element changes layout or appearance, the But, what should happen if, mid-transition:
And does the behaviour change depending on if the The following options assume that the linking of source elements to It also assumes that "the element is no longer renderable" check is performed in the render steps, when the view transition currently updates its state per frame. Option 1: Skip the transitionIf the transition starts with a Option 2: Adapt the transition, no backsiesIf the element is no longer renderable: If the group has a This puts the However, this would cause If the group does not have a If the element becomes renderable again, no action is taken. Option 3: Adapt the transition, with backsiesIf the element is no longer renderable, the group's associated If the group has a This is mostly as if If the group does not have a If the element becomes renderable again, the state is updated again, allowing the element to reappear. The two "adapt the transition" options seem to have weird trade-offs, so I think I'm happiest with option 1. |
Thanks for the summary @jakearchibald. +1 to option 1. Toggling of this state mid-transition seems like a bug rather than a pattern the developer would need for a particular UX. |
Reiterating the proposed resolution : "If constraints on new elements participating in a transition become unsatisfied mid-transition, the transition is aborted." Note that this issue is limited to the behaviour if the constraints are changed by the developer during the transition. The exact constraints are already in the spec with active discussion on clarifying/relaxing them:
|
Since there is a clear resolution and agreement here in the issue, let’s try making this an async resolution. The CSSWG will automatically accept this resolution one week from now if no objections are raised here. Anyone can add an emoji to this comment to express support. If you do not support this resolution, please add a new comment. proposed resolution : If constraints on new elements participating in a transition become unsatisfied mid-transition, the transition is aborted. |
This patch removes the containment requirement from view-transitions. This is to align with proposed resolution w3c/csswg-drafts#7882 [email protected], [email protected] Fixed: 1409491 Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36
This patch removes the containment requirement from view-transitions. This is to align with proposed resolution w3c/csswg-drafts#7882 [email protected], [email protected] Fixed: 1409491 Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 Reviewed-by: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096187}
This patch removes the containment requirement from view-transitions. This is to align with proposed resolution w3c/csswg-drafts#7882 [email protected], [email protected] Fixed: 1409491 Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 Reviewed-by: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096187}
This patch removes the containment requirement from view-transitions. This is to align with proposed resolution w3c/csswg-drafts#7882 [email protected], [email protected] Fixed: 1409491 Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 Reviewed-by: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096187}
This reverts commit e554cf3. Reason for revert: Decided against this feature for now. Original change's description: > VT: Remove containment requirement. > > This patch removes the containment requirement from view-transitions. > > This is to align with proposed resolution > w3c/csswg-drafts#7882 > > R=[email protected], [email protected] > > Fixed: 1409491 > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > Reviewed-by: David Bokan <[email protected]> > Reviewed-by: Khushal Sagar <[email protected]> > Commit-Queue: Vladimir Levin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096187} Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 Commit-Queue: Vladimir Levin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096273}
This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. Reason for revert: Decided against this feature for now. Original change's description: > VT: Remove containment requirement. > > This patch removes the containment requirement from view-transitions. > > This is to align with proposed resolution > w3c/csswg-drafts#7882 > > R=[email protected], [email protected] > > Fixed: 1409491 > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > Reviewed-by: David Bokan <[email protected]> > Reviewed-by: Khushal Sagar <[email protected]> > Commit-Queue: Vladimir Levin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096187} Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 Commit-Queue: Vladimir Levin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096273}
This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. Reason for revert: Decided against this feature for now. Original change's description: > VT: Remove containment requirement. > > This patch removes the containment requirement from view-transitions. > > This is to align with proposed resolution > w3c/csswg-drafts#7882 > > R=[email protected], [email protected] > > Fixed: 1409491 > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > Reviewed-by: David Bokan <[email protected]> > Reviewed-by: Khushal Sagar <[email protected]> > Commit-Queue: Vladimir Levin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096187} Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 Commit-Queue: Vladimir Levin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096273}
RESOLVED : If constraints on new elements participating in a transition become unsatisfied mid-transition, the transition is aborted. |
…estonly Automatic update from web-platform-tests VT: Remove containment requirement. This patch removes the containment requirement from view-transitions. This is to align with proposed resolution w3c/csswg-drafts#7882 [email protected], [email protected] Fixed: 1409491 Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 Reviewed-by: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096187} -- wpt-commits: d472d427d182823de6e8bc7e629e58a605c45d7c wpt-pr: 38128
…nt.", a=testonly Automatic update from web-platform-tests Revert "VT: Remove containment requirement." This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. Reason for revert: Decided against this feature for now. Original change's description: > VT: Remove containment requirement. > > This patch removes the containment requirement from view-transitions. > > This is to align with proposed resolution > w3c/csswg-drafts#7882 > > R=[email protected], [email protected] > > Fixed: 1409491 > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > Reviewed-by: David Bokan <[email protected]> > Reviewed-by: Khushal Sagar <[email protected]> > Commit-Queue: Vladimir Levin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096187} Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 Commit-Queue: Vladimir Levin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096273} -- wpt-commits: 404735f5905970d19b54fc1c4e9f84ef19edaac3 wpt-pr: 38144
…estonly Automatic update from web-platform-tests VT: Remove containment requirement. This patch removes the containment requirement from view-transitions. This is to align with proposed resolution w3c/csswg-drafts#7882 [email protected], [email protected] Fixed: 1409491 Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 Reviewed-by: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096187} -- wpt-commits: d472d427d182823de6e8bc7e629e58a605c45d7c wpt-pr: 38128
…nt.", a=testonly Automatic update from web-platform-tests Revert "VT: Remove containment requirement." This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. Reason for revert: Decided against this feature for now. Original change's description: > VT: Remove containment requirement. > > This patch removes the containment requirement from view-transitions. > > This is to align with proposed resolution > w3c/csswg-drafts#7882 > > R=[email protected], [email protected] > > Fixed: 1409491 > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > Reviewed-by: David Bokan <[email protected]> > Reviewed-by: Khushal Sagar <[email protected]> > Commit-Queue: Vladimir Levin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096187} Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 Commit-Queue: Vladimir Levin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096273} -- wpt-commits: 404735f5905970d19b54fc1c4e9f84ef19edaac3 wpt-pr: 38144
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=[email protected], [email protected] > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <[email protected]> > > Reviewed-by: Khushal Sagar <[email protected]> > > Commit-Queue: Vladimir Levin <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096273} Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105
This reverts commit f2820f7. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf3. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=[email protected], [email protected] > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <[email protected]> > > Reviewed-by: Khushal Sagar <[email protected]> > > Commit-Queue: Vladimir Levin <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096273} Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087 Commit-Queue: Vladimir Levin <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1102856}
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=[email protected], [email protected] > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <[email protected]> > > Reviewed-by: Khushal Sagar <[email protected]> > > Commit-Queue: Vladimir Levin <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096273} Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087 Commit-Queue: Vladimir Levin <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1102856}
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=[email protected], [email protected] > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <[email protected]> > > Reviewed-by: Khushal Sagar <[email protected]> > > Commit-Queue: Vladimir Levin <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096273} Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087 Commit-Queue: Vladimir Levin <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1102856}
…nt.", a=testonly Automatic update from web-platform-tests Reland "VT: Remove containment requirement." This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=[email protected], [email protected] > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <[email protected]> > > Reviewed-by: Khushal Sagar <[email protected]> > > Commit-Queue: Vladimir Levin <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096273} Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087 Commit-Queue: Vladimir Levin <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1102856} -- wpt-commits: 8304fd86ce591ba34f172f46f5fadc017a4db814 wpt-pr: 38421
…nt.", a=testonly Automatic update from web-platform-tests Reland "VT: Remove containment requirement." This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=[email protected], [email protected] > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <[email protected]> > > Reviewed-by: Khushal Sagar <[email protected]> > > Commit-Queue: Vladimir Levin <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096273} Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087 Commit-Queue: Vladimir Levin <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1102856} -- wpt-commits: 8304fd86ce591ba34f172f46f5fadc017a4db814 wpt-pr: 38421
This reverts commit f2820f7. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf3. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=[email protected], [email protected] > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <[email protected]> > > Reviewed-by: Khushal Sagar <[email protected]> > > Commit-Queue: Vladimir Levin <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096273} (cherry picked from commit 652c5ff) Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087 Commit-Queue: Vladimir Levin <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1102856} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233792 Commit-Queue: Xianzhu Wang <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Cr-Commit-Position: refs/branch-heads/5563@{#318} Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
This patch removes the containment requirement from view-transitions. This is to align with proposed resolution w3c/csswg-drafts#7882 [email protected], [email protected] Fixed: 1409491 Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 Reviewed-by: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096187}
This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. Reason for revert: Decided against this feature for now. Original change's description: > VT: Remove containment requirement. > > This patch removes the containment requirement from view-transitions. > > This is to align with proposed resolution > w3c/csswg-drafts#7882 > > R=[email protected], [email protected] > > Fixed: 1409491 > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > Reviewed-by: David Bokan <[email protected]> > Reviewed-by: Khushal Sagar <[email protected]> > Commit-Queue: Vladimir Levin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096187} Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 Commit-Queue: Vladimir Levin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096273}
This reverts commit f2820f7b99c149d989dee94c1b23c791a7b5f387. This was reverted earlier to wait for CSSWG feedback. The resolution aligns with the behaviour in this patch. w3c/csswg-drafts#8139 Original change's description: > Revert "VT: Remove containment requirement." > > This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. > > Reason for revert: Decided against this feature for now. > > Original change's description: > > VT: Remove containment requirement. > > > > This patch removes the containment requirement from view-transitions. > > > > This is to align with proposed resolution > > w3c/csswg-drafts#7882 > > > > R=[email protected], [email protected] > > > > Fixed: 1409491 > > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > > Reviewed-by: David Bokan <[email protected]> > > Reviewed-by: Khushal Sagar <[email protected]> > > Commit-Queue: Vladimir Levin <[email protected]> > > Cr-Commit-Position: refs/heads/main@{#1096187} > > Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 > Commit-Queue: Vladimir Levin <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096273} Change-Id: I3da1ee9d5e00b2a9470b99b5f69704fc9b4d0105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4233087 Commit-Queue: Vladimir Levin <[email protected]> Commit-Queue: Khushal Sagar <[email protected]> Auto-Submit: Khushal Sagar <[email protected]> Reviewed-by: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1102856}
…estonly Automatic update from web-platform-tests VT: Remove containment requirement. This patch removes the containment requirement from view-transitions. This is to align with proposed resolution w3c/csswg-drafts#7882 [email protected], [email protected] Fixed: 1409491 Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 Reviewed-by: David Bokan <[email protected]> Reviewed-by: Khushal Sagar <[email protected]> Commit-Queue: Vladimir Levin <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096187} -- wpt-commits: d472d427d182823de6e8bc7e629e58a605c45d7c wpt-pr: 38128
…nt.", a=testonly Automatic update from web-platform-tests Revert "VT: Remove containment requirement." This reverts commit e554cf340761c4b11e0da4d0c98b1b58f9189cbd. Reason for revert: Decided against this feature for now. Original change's description: > VT: Remove containment requirement. > > This patch removes the containment requirement from view-transitions. > > This is to align with proposed resolution > w3c/csswg-drafts#7882 > > R=[email protected], [email protected] > > Fixed: 1409491 > Change-Id: Iad0eb54c8d2de503f209a58a9f438e586fcd6a36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4188811 > Reviewed-by: David Bokan <[email protected]> > Reviewed-by: Khushal Sagar <[email protected]> > Commit-Queue: Vladimir Levin <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1096187} Change-Id: Id0b58230eb372a96aa1f1dff2e7d84e2f297219f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4192788 Commit-Queue: Vladimir Levin <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/heads/main@{#1096273} -- wpt-commits: 404735f5905970d19b54fc1c4e9f84ef19edaac3 wpt-pr: 38144
View transitions require a bunch of constraints to be satisfied by tagged elements listed here:
This state can also change mid transition. The simplest thing is to skip the transition in this case.
The text was updated successfully, but these errors were encountered: