Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add proposed search element #355

Merged
merged 7 commits into from
Mar 24, 2023
Merged

add proposed search element #355

merged 7 commits into from
Mar 24, 2023

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Nov 8, 2021 •
edited by pr-preview bot

The proposed search element (whatwg/html#7320) would map to role=search in Core AAM.

closes #369

Preview | Diff

@scottaohara
add proposed search element
24b1534 
The proposed `search` element would map to `role=search` in Core AAM.

**TODO 1:**
If a `<search>` were to contain a `<form>` element, will need to indicate to user agents that they must not expose the `<form>` as a landmark.

Question: if an author has given the `<form>` an accName, ignore this rule, or, should this be used as a way to name a `<search>` in its accName calculation?

**TODO 2:**
Add `<search>` to accName/Description section
@scottaohara scottaohara mentioned this pull request Feb 4, 2022
Closed
@domenic domenic mentioned this pull request Feb 4, 2022
Merged
7 tasks
@scottaohara
Copy link
Member Author

just commenting to say that the build will continue to report an error until HTML has merged the new search element. This should not block merging here, when ready to do so.

@zcorpan
Copy link
Member

zcorpan commented Mar 24, 2023

Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1824121
Safari: https://bugs.webkit.org/show_bug.cgi?id=254327

@scottaohara
Copy link
Member Author

thank you @zcorpan

@scottaohara scottaohara merged commit e8d3b12 into gh-pages Mar 24, 2023
@scottaohara scottaohara deleted the search-element branch March 24, 2023 10:37
@cmorten cmorten mentioned this pull request Jul 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcorpan zcorpan zcorpan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mappings for proposed <search> element
2 participants
@scottaohara @zcorpan