Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addition: update figure role allowances #415

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Addition: update figure role allowances #415

merged 9 commits into from
Feb 13, 2023

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Apr 16, 2022 •
edited by pr-preview bot

closes #412

As discussed in w3c/dpub-aria#42 (comment), doc-example is a dpub variant of the figure role. This role being the same as figure but with the opportunity of being exposed as an "example" for its role description, needs to be an allowed role for the figure element.

create test case

Expected results:
doc-example is an allowed role for <figure role=doc-example>...<figcaption>...</figcaption>
figure results in a warning as unnecessary for <figure role=figure>...<figcaption>...</figcaption>
no other roles are allowed if a figcaption is a child of a figure element.

Preview | Diff

@scottaohara
Addition: update figure role allowances
59df2d8 
closes #412

As discussed in w3c/dpub-aria#42 (comment), `doc-example` is a dpub variant of the `figure` role.  This role being the same as `figure` but with the opportunity of being exposed as an "example" for its role description, needs to be an allowed role for the `figure` element.
@scottaohara scottaohara added needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. needs changelog entry once 2 implementations land, we can merge and note it in our changelog. labels Apr 16, 2022
This was referenced Apr 16, 2022
Closed
Open
scottaohara
scottaohara commented Apr 26, 2022
View reviewed changes
index.html Outdated Show resolved Hide resolved
@scottaohara scottaohara mentioned this pull request Apr 26, 2022
Open
@stevefaulkner stevefaulkner self-requested a review July 13, 2022 12:30
@scottaohara
Copy link
Member Author

merging as arc toolkit and axe do not report errors when using this role on figure element

@scottaohara scottaohara added Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge. and removed needs implementation commitment Cannot merge into spec until implementations in conformance checkers has been confirmed. needs changelog entry once 2 implementations land, we can merge and note it in our changelog. labels Feb 13, 2023
@scottaohara scottaohara merged commit 0f29858 into gh-pages Feb 13, 2023
@scottaohara scottaohara deleted the issue-412 branch February 13, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevefaulkner stevefaulkner stevefaulkner approved these changes

Assignees
No one assigned
Labels
Meets 2 implementations req Indicates that a spec change has met the necessary 2 implementations needed to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correction: allow doc-example role on figure with figcaption
2 participants
@scottaohara @stevefaulkner