-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify and consolidate img ARIA allowances #453
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to progressbar, meter should thus also be allowed.
This was referenced Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Allowed roles
Pertaining to the allowed roles of HTML elements
Meets 2 implementations req
Indicates that a spec change has met the necessary 2 implementations needed to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #424 and #452
This update serves to both clarify that an image with a name, regardless of how that name is provided, should allow the specified roles.
Additionally, it consolidates the expectations for an image with an empty alt, or a missing alt so long as they also have no accessible name.
Using the implicit role of the image, for all instances, has already been marked as not recommended, so errors should not be exposed for that, but rather warnings, if the conformance checker exposes non-error messages.
Test cases for the passing examples
Preview | Diff