Handle pointer capture node removal asynchronously #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this looks good to me (covers option 1 suggested by @mustaqahmed on #487) |
mustaqahmed
reviewed
Oct 30, 2023
mustaqahmed
reviewed
Nov 2, 2023
mustaqahmed
approved these changes
Nov 7, 2023
smaug----
approved these changes
Nov 8, 2023
|
Does this need a WPT? |
|
This should be tested by pointerevents/pointerevent_lostpointercapture_for_disconnected_node.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This explains what happens when the current pointer capture target is removed or the pending pointer capture target is removed - addressing the concern raised in #487. The pointer capture is updated during the next process pending pointer capture which occurs before the dispatch of the next pointer event.
Preview | Diff