Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "list of available images" and origin #5674

Open
yutakahirano opened this issue Jun 25, 2020 · 6 comments
Open

The "list of available images" and origin #5674

yutakahirano opened this issue Jun 25, 2020 · 6 comments

Comments

@yutakahirano
Copy link
Member

Hi,

Currently https://html.spec.whatwg.org/multipage/images.html#the-list-of-available-images says:

Each Document object must have a list of available images. Each image in this list is identified by a tuple consisting of an absolute URL, a CORS settings attribute mode, and, if the mode is not No CORS, an origin.

I think we should always attach the origin to the matching key, because that information is pretty important even for No CORS images - CORS-sameoriginness is one example.

cc: @domfarolino

@domfarolino
Copy link
Member

This seems reasonable. Any objections?

@annevk
Copy link
Member

annevk commented Jun 26, 2020

Is this a general property of "memory cache" keys? It makes sense to me it cannot span origins. It should not be able to span top-level sites either, but that's probably best tackled separately.

cc @emilio

@domfarolino
Copy link
Member

Chrome's memory cache is effectively keyed by requestor origin as well, so I think this is general property for us at least.

@emilio
Copy link
Contributor

emilio commented Jun 26, 2020

Sure, but I don't get why the key needs to be in the document's "list of available images". Why is that desirable? For a given document, the origin is always the same, right? (maybe modulo document.domain shenanigans). If so I don't get how it is useful.

@domfarolino
Copy link
Member

I believe the spec allows for a document’s list of available images to be shared with any other document at any time

@emilio
Copy link
Contributor

emilio commented Jun 26, 2020

Yeah, it seems like then we should key off the origin then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants