There's possibly other JS that loads on diff pages which also should be triggered.
There is mw.hook( 'wikipage.diff' ).fire( $wikiDiff.find( 'table.diff' ) );, but that runs on preview, which we don't put thanks links up for...
I had a quick look around and couldn't really find a specific diff hook to be firing!
We do currntly fire the following on reload:
mw.hook( 'wikipage.content' ).fire( $contentText );
And we could always introduce another hook?
Change 306677 had a related patch set uploaded (by WMDE-leszek):
Add an extension-specific hook for the diff reload event
Change 306679 had a related patch set uploaded (by WMDE-leszek):
Re-add actions to Thanks links when Revision Slider reloads a diff
Instead of an extension specific one, can we have a generic hook that is triggered on diff page views by core, and then revisionslider can update it when it changes the diff?
Change 306679 merged by jenkins-bot:
Re-add actions to Thanks links when Revision Slider reloads a diff
Change 307316 had a related patch set uploaded (by WMDE-leszek):
Add a hook trigged when the diff on the diff page changes
Change 307317 had a related patch set uploaded (by WMDE-leszek):
Re-add actions to Thanks links when a diff on the diff page changes
@Legoktm yes, this makes sense.
I've submitted https://gerrit.wikimedia.org/r/307316 and https://gerrit.wikimedia.org/r/307317 then, and adjusted https://gerrit.wikimedia.org/r/#/c/306677/. I am still not sure about name of the new hook and if it was added to a right place (in all those resource subdirs structure etc).
Change 310229 had a related patch set uploaded (by Addshore):
Listen to the wikipage.diff hook for adding JS links
Change 310231 had a related patch set uploaded (by Addshore):
Fire wikipage.diff instead of revslider.diffreload
Change 310232 had a related patch set uploaded (by Addshore):
Stop listening to revslider.diffreload hook
Change 310229 merged by jenkins-bot:
Listen to the wikipage.diff hook for adding JS links
Change 310231 merged by jenkins-bot:
Fire wikipage.diff instead of revslider.diffreload
Change 307316 abandoned by WMDE-leszek:
Add a hook trigged when the diff on the diff page changes
Reason:
What Krinkle said makes perfect sense, and there is no need to add a new hook.
Change 307317 abandoned by WMDE-leszek:
Re-add actions to Thanks links when a diff on the diff page changes
Reason:
New core hook is not needed what makes this change foobar
Change 306677 abandoned by WMDE-leszek:
Trigger the hook when the diff content changes
Reason:
Superseded by Ie88021abb2325cc6259cf2fb041fbdca4ae9ca89
It looks like this is happening again and needs some more investigation.
I have just confirmed this on testwiki and mw.org
@Addshore, remember I told you months ago that the hook does not always work? For WikEdDiff and for thanks for example. I can see you recognized it too.
Change 347822 had a related patch set uploaded (by WMDE-Fisch):
[mediawiki/extensions/RevisionSlider@master] Fix JS trigger for the thanks links
Change 347822 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Fix JS trigger for the thanks links