fix(eslint-plugin): [no-extraneous-class] handle abstract members #9367

yoshi2no · 2024-06-16T07:21:05Z

PR Checklist

Addresses an existing open issue: fixes Bug: no-extraneous-class triggered on abstract class that does not contain any static methods #9359
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Description
This PR addresses an issue with the @typescript-eslint/no-extraneous-class rule where abstract fields and methods were not being counted as instance properties. The rule implementation was missing the handling of abstract members, which have different AST nodes compared to their concrete counterparts. This fix ensures that abstract fields and methods are correctly recognized as instance properties.

Changes

Updated the no-extraneous-class rule to account for TSAbstractMethodDefinition and TSAbstractPropertyDefinition nodes.
Added tests to cover scenarios with abstract classes containing abstract members.

typescript-eslint · 2024-06-16T07:21:09Z

Thanks for the PR, @yoshi2no!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-06-16T07:21:24Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`66770d2`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66731d9c0bbda10008c32e2a
😎 Deploy Preview	https://deploy-preview-9367--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-06-16T07:22:16Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 66770d2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

nx run repo-tools:postinstall-script

Sent with 💌 from NxCloud.

kirkwaiblinger

@yoshi2no

Congrats on a great first PR to typescript-eslint!

AFAICT, everything that you have so far is perfect! The changes requested are just for a few finishing touches 🙂 Only blocker for me is the request around testing.

Thanks!

packages/eslint-plugin/tests/rules/no-extraneous-class.test.ts

packages/eslint-plugin/src/rules/no-extraneous-class.ts

Josh-Cena · 2024-06-16T17:02:37Z

Also, TIL that static abstract is not legal. Maybe we should have this as a comment.

kirkwaiblinger

Great stuff! Just one nit remaining

kirkwaiblinger · 2024-06-19T17:19:13Z

packages/eslint-plugin/docs/rules/no-extraneous-class.mdx

@@ -44,6 +44,10 @@ class HelloWorldLogger {
 }
 ```

+```ts


nit - please include these in the preceeding tabs, rather than making a new one

kirkwaiblinger · 2024-06-19T17:27:09Z

FYI - to fix the CI failure, you'll need to update the docs snapshots. See https://typescript-eslint.io/contributing/local-development#rule-development

yoshi2no · 2024-06-19T18:20:46Z

FYI - to fix the CI failure, you'll need to update the docs snapshots. See https://typescript-eslint.io/contributing/local-development#rule-development

Oops, I missed that. Thanks!

kirkwaiblinger

Great work! 🚀

Marking "1 approval" for now, for another team member to take a pass as well before merging

JoshuaKGoldberg

Yay!

fix(eslint-plugin): handle abstract members in no-extraneous-class rule

1515ef6

yoshi2no changed the title ~~fix(eslint-plugin): handle abstract members in no-extraneous-class rule~~ fix(eslint-plugin): [no-extraneous-class] handle abstract members Jun 16, 2024

kirkwaiblinger requested changes Jun 16, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/no-extraneous-class.test.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-extraneous-class.ts Outdated Show resolved Hide resolved

kirkwaiblinger added bug Something isn't working awaiting response Issues waiting for a reply from the OP or another party labels Jun 16, 2024

yoshi2no added 3 commits June 20, 2024 00:23

chore(eslint-plugin): add tests for abstract classes

f377c27

docs(eslint-plugin): add example for abstract class

19a25e3

chore(eslint-plugin): add comment to clarify static abstract support

c126415

yoshi2no requested a review from kirkwaiblinger June 19, 2024 17:10

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 19, 2024

kirkwaiblinger requested changes Jun 19, 2024

View reviewed changes

yoshi2no added 3 commits June 20, 2024 02:46

chore(eslint-plugin): update doc snapshot

97dd73f

docs(website): include abstract class example in the preceding tabs

a570789

chore(eslint-plugin): update doc snapshot

66770d2

yoshi2no requested a review from kirkwaiblinger June 19, 2024 18:22

kirkwaiblinger approved these changes Jun 19, 2024

View reviewed changes

JoshuaKGoldberg approved these changes Jun 22, 2024

View reviewed changes

JoshuaKGoldberg merged commit e47123d into typescript-eslint:main Jun 22, 2024
62 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [no-extraneous-class] handle abstract members #9367

fix(eslint-plugin): [no-extraneous-class] handle abstract members #9367

yoshi2no commented Jun 16, 2024

typescript-eslint bot commented Jun 16, 2024

netlify bot commented Jun 16, 2024 •

edited

Loading

nx-cloud bot commented Jun 16, 2024 •

edited

Loading

kirkwaiblinger left a comment

Josh-Cena commented Jun 16, 2024

kirkwaiblinger left a comment

kirkwaiblinger Jun 19, 2024

kirkwaiblinger commented Jun 19, 2024

yoshi2no commented Jun 19, 2024

kirkwaiblinger left a comment

JoshuaKGoldberg left a comment

@@ @@ -44,6 +44,10 @@ class HelloWorldLogger { @@
               }
               ```
+              ```ts

fix(eslint-plugin): [no-extraneous-class] handle abstract members #9367

fix(eslint-plugin): [no-extraneous-class] handle abstract members #9367

Conversation

yoshi2no commented Jun 16, 2024

PR Checklist

Overview

typescript-eslint bot commented Jun 16, 2024

netlify bot commented Jun 16, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Jun 16, 2024 • edited Loading

☁️ Nx Cloud Report

kirkwaiblinger left a comment

Choose a reason for hiding this comment

Josh-Cena commented Jun 16, 2024

kirkwaiblinger left a comment

Choose a reason for hiding this comment

kirkwaiblinger Jun 19, 2024

Choose a reason for hiding this comment

kirkwaiblinger commented Jun 19, 2024

yoshi2no commented Jun 19, 2024

kirkwaiblinger left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

netlify bot commented Jun 16, 2024 •

edited

Loading

nx-cloud bot commented Jun 16, 2024 •

edited

Loading