-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add parseInt
to constructor of task keys
#436
Conversation
The `id` property of `Key` is a string, update the use site of the key to parse it as an int when being used to create a key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want to use datastore.int(taskId)
instead of parseInt
. Technically both will work, but it would be great to include some of the built in helpers methods into a sample (they sometimes get missed)
The `id` property of `Key` is a string, update the use site of the key to parse it as an int when being used to create a key.
Thanks, I didn't know that function existed. Pushed a new commit using |
Codecov Report
@@ Coverage Diff @@
## master #436 +/- ##
=======================================
Coverage 98.05% 98.05%
=======================================
Files 5 5
Lines 617 617
Branches 145 145
=======================================
Hits 605 605
Partials 12 12 Continue to review full report at Codecov.
|
The
id
property ofKey
is a string, update the use site of the keyto parse it as an int when being used to create a key.