feat: excludeFromIndex allow for '*' wildcard to catch all properties on object #451

praveenqlogic01 · 2019-06-28T07:26:54Z

towards #12

Tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

src/request.ts

codecov · 2019-07-02T15:43:06Z

Codecov Report

Merging #451 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   98.05%   98.12%   +0.06%     
==========================================
  Files           5        5              
  Lines         617      639      +22     
  Branches      145      153       +8     
==========================================
+ Hits          605      627      +22     
  Partials       12       12

Impacted Files	Coverage Δ
src/entity.ts	`98.31% <100%> (+0.17%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1850f25...8f54581. Read the comment docs.

jacekkopecky · 2019-07-18T19:59:49Z

Thank you, this will be oh so useful!

Is there documentation anywhere?

It seems that prop.* excludes everything under the property prop; and there's a hint that a simple .* excludes everything. Is that correct?

If so, shouldn't that be just * instead? Why the initial dot?

system-test/datastore.ts

praveenqlogic01 · 2019-07-19T04:16:22Z

Thank you, this will be oh so useful!

Is there documentation anywhere?

It seems that prop.* excludes everything under the property prop; and there's a hint that a simple .* excludes everything. Is that correct?

If so, shouldn't that be just * instead? Why the initial dot?

@jacekkopecky Hi, yes you are right, regarding ".*", "." is representing root path here and * representing everything from there!

googlebot · 2019-07-25T01:07:15Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

praveenqlogic01 · 2019-07-25T06:11:51Z

verifying cla done!

googlebot · 2019-07-25T06:11:56Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

uschtwill · 2021-05-19T16:36:32Z

This isn't documented at all, is it?

siddjain · 2022-10-28T23:37:44Z

test/request.ts

+        {
+          key,
+          data,
+          excludeFromIndexes: [


how can i exclude all properties from being indexed? will ['*'] do it?

kirillgroshkov · 2024-01-04T16:43:46Z

Is there documentation for this except source code of this pull request?

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 28, 2019

stephenplusplus reviewed Jun 28, 2019

View reviewed changes

src/request.ts Outdated Show resolved Hide resolved

praveenqlogic01 force-pushed the nodejs-datastore-issue-12 branch from a0d7aaf to 25196ef Compare July 2, 2019 10:33

AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019

AVaksman added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 2, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 2, 2019

praveenqlogic01 force-pushed the nodejs-datastore-issue-12 branch from 25196ef to f4c38fb Compare July 3, 2019 06:21

AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019

AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2019

stephenplusplus approved these changes Jul 17, 2019

View reviewed changes

stephenplusplus mentioned this pull request Jul 17, 2019

[datastore] new excludeFromIndexes syntax should allow for a catch-all on object properties #12

Closed

jacekkopecky reviewed Jul 18, 2019

View reviewed changes

system-test/datastore.ts Outdated Show resolved Hide resolved

Praveen Kumar Singh added 4 commits July 19, 2019 09:35

implemented wildcard '*' for excludeFromIndex array

adf088b

added system-test for wildcard '*' for excludeFromIndex array

3475c45

implemented wildcard behavior in excludePathFromEntity function

3309398

fix typo mistake - datastore system-test

b3f9da0

praveenqlogic01 force-pushed the nodejs-datastore-issue-12 branch from 6ef8819 to b3f9da0 Compare July 19, 2019 04:11

AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 24, 2019

Merge branch 'master' into nodejs-datastore-issue-12

220543f

googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Jul 25, 2019

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 25, 2019

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 25, 2019

JustinBeckwith changed the title ~~excludeFromIndex allow for '*' wildcard to catch all properties on object.~~ feat: excludeFromIndex allow for '*' wildcard to catch all properties on object Jul 25, 2019

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2019

Merge branch 'master' into nodejs-datastore-issue-12

8f54581

JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2019

JustinBeckwith merged commit 215cbee into googleapis:master Jul 26, 2019

tanishiking mentioned this pull request Feb 1, 2021

excludeFromIndexes using wildcard on non-existing data causes TypeError: Cannot read property 'entityValue' of undefined. #787

Closed

siddjain reviewed Oct 28, 2022

View reviewed changes

test/request.ts

{

key,

data,

excludeFromIndexes: [

Copy link

siddjain Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can i exclude all properties from being indexed? will ['*'] do it?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: excludeFromIndex allow for '*' wildcard to catch all properties on object #451

feat: excludeFromIndex allow for '*' wildcard to catch all properties on object #451

praveenqlogic01 commented Jun 28, 2019

codecov bot commented Jul 2, 2019 •

edited

Loading

jacekkopecky commented Jul 18, 2019

praveenqlogic01 commented Jul 19, 2019 •

edited

Loading

googlebot commented Jul 25, 2019

praveenqlogic01 commented Jul 25, 2019

googlebot commented Jul 25, 2019

uschtwill commented May 19, 2021

siddjain Oct 28, 2022

kirillgroshkov commented Jan 4, 2024

feat: excludeFromIndex allow for '*' wildcard to catch all properties on object #451

feat: excludeFromIndex allow for '*' wildcard to catch all properties on object #451

Conversation

praveenqlogic01 commented Jun 28, 2019

codecov bot commented Jul 2, 2019 • edited Loading

Codecov Report

jacekkopecky commented Jul 18, 2019

praveenqlogic01 commented Jul 19, 2019 • edited Loading

googlebot commented Jul 25, 2019

praveenqlogic01 commented Jul 25, 2019

googlebot commented Jul 25, 2019

uschtwill commented May 19, 2021

siddjain Oct 28, 2022

Choose a reason for hiding this comment

kirillgroshkov commented Jan 4, 2024

codecov bot commented Jul 2, 2019 •

edited

Loading

praveenqlogic01 commented Jul 19, 2019 •

edited

Loading