fix(types): correct type of Datastore.KEY #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`entity.KEY_SYMBOL` is defined as a `unique symbol` and without explicit reference back to the original type, the `unique symbol` flows into a regular `symbol`, which loses some of its semantic meaning. This guarantees that `Datastore.KEY` and `entity.KEY_SYMBOL` (and `new Datastore().KEY`) are truly equivalent within the type system.
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 98.12% 98.12%
=======================================
Files 5 5
Lines 639 639
Branches 153 153
=======================================
Hits 627 627
Partials 12 12
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entity.KEY_SYMBOLis defined as aunique symboland without explicit reference back to the original type, theunique symbolflows into a regularsymbol, which loses some of its semantic meaning.This guarantees that
Datastore.KEYandentity.KEY_SYMBOL(andnew Datastore().KEY) are truly equivalent within the type system.