Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed duplicate declaration of Entities #524

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

laljikanjareeya
Copy link
Contributor

@laljikanjareeya laljikanjareeya commented Nov 4, 2019

Fixes #523

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2019
@codecov
Copy link

codecov bot commented Nov 4, 2019

Codecov Report

Merging #524 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files           6        6           
  Lines         745      745           
  Branches      175      175           
=======================================
  Hits          732      732           
  Misses          2        2           
  Partials       11       11
Impacted Files Coverage Δ
src/entity.ts 98.73% <ø> (ø) ⬆️
src/request.ts 99.54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2fb3c...6ad458e. Read the comment docs.

@bcoe bcoe merged commit 26cbb67 into googleapis:master Nov 4, 2019
@laljikanjareeya laljikanjareeya deleted the duplicate-entities-type branch November 5, 2019 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplication of Entities type within entity.ts
3 participants