feat: add warning when int value is too large during upload #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
reviewed
Feb 20, 2020
src/entity.ts
Outdated
| @@ -580,6 +580,15 @@ export namespace entity { | |||
|
|
|||
| if (typeof value === 'number') { | |||
| if (value % 1 === 0) { | |||
There was a problem hiding this comment.
what is the purpose of value % 1, this seems like it could use a comment (even though it wasn't added by you).
There was a problem hiding this comment.
Done.
Would it be preferable to do
if (Number.isInteger(value)) {
...
}instead? Here the method's name speaks for itself.
There was a problem hiding this comment.
Swapped the logic toNumber.isInteger(value)
bcoe
approved these changes
Feb 20, 2020
stephenplusplus
suggested changes
Feb 21, 2020
stephenplusplus
approved these changes
Feb 27, 2020
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #588