Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Key and Entity. #749

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Export Key and Entity. #749

merged 1 commit into from
Nov 9, 2020

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Nov 3, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #568 by exporting Key and Entity.

Tested: copied the generated .d.ts to one of my project and makes sure I can use the Key type.

[...]
import { Entities, entity, Entity, ValueProto } from './entity';
import Key = entity.Key;
export {Entity, Key};

@vicb vicb requested a review from a team as a code owner November 3, 2020 17:43
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 3, 2020
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/nodejs-datastore API. label Nov 3, 2020
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #749 (2eb6692) into master (07a77fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files          11       11           
  Lines        7890     7893    +3     
  Branches      470      470           
=======================================
+ Hits         7807     7810    +3     
  Misses         81       81           
  Partials        2        2           
Impacted Files Coverage Δ
src/index.ts 99.83% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07a77fe...2eb6692. Read the comment docs.

@vicb
Copy link
Contributor Author

vicb commented Nov 6, 2020

@stephenplusplus anything missing from this PR to be mergeable ?

/cc @cgfrost

@vicb vicb changed the title Export entity and Entity. Export Key and Entity. Nov 7, 2020
@stephenplusplus
Copy link
Contributor

@vicb Sorry for the delay, LGTM! I'll wait out the CI and try to get this released today.

@stephenplusplus stephenplusplus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 9, 2020
@stephenplusplus stephenplusplus merged commit f4c8d0b into googleapis:master Nov 9, 2020
@vicb
Copy link
Contributor Author

vicb commented Nov 9, 2020

Thanks a lor @stephenplusplus

@vicb vicb deleted the types branch November 9, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the googleapis/nodejs-datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export types for Key and Entity
3 participants