fix(types): assert in typescript 3.7 #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwlui
commented
May 19, 2020
| assert(bucket instanceof ServiceObject); | ||
| // Using assert.strictEqual instead of assert to prevent | ||
| // coercing of types. | ||
| assert.strictEqual(bucket instanceof ServiceObject, true); |
There was a problem hiding this comment.
This causes the compiler to recognise bucket as type ServiceObject, rather than any, which causes the line below to fail.
I'm starting to think we should probably rewrite our tests in sinon.
Codecov Report
@@ Coverage Diff @@
## master #1198 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 12 12
Lines 11471 11471
Branches 597 530 -67
=======================================
Hits 11377 11377
Misses 94 94 Continue to review full report at Codecov.
|
Merged
bcoe
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI started to fail overnight on some assertions in our tests. I believe this has to do with Assertion Functions in TS3.7.
What I basically did in this PR is simply patching the breakrages, as I'm not sure how to proceed otherwise.
Calling on all node/ts experts @googleapis/yoshi-nodejs