Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): explain manual pagination and add usage sample #1317

Merged
merged 14 commits into from
Nov 17, 2020

Conversation

AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Oct 19, 2020

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1277

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2020
@AVaksman AVaksman marked this pull request as ready for review October 19, 2020 17:33
@AVaksman AVaksman requested a review from a team as a code owner October 19, 2020 17:33
@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/nodejs-storage API. samples Issues that are directly related to samples. labels Oct 20, 2020
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #1317 (3378b60) into master (642a9df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1317   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          14       14           
  Lines       11775    11799   +24     
  Branches      593      524   -69     
=======================================
+ Hits        11658    11682   +24     
  Misses        117      117           
Impacted Files Coverage Δ
src/bucket.ts 99.53% <100.00%> (+<0.01%) ⬆️
src/storage.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 642a9df...3378b60. Read the comment docs.

samples/listFilesPaginate.js Outdated Show resolved Hide resolved
samples/listFilesPaginate.js Outdated Show resolved Hide resolved
samples/listFilesPaginate.js Show resolved Hide resolved
@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2020
@snippet-bot
Copy link

snippet-bot bot commented Nov 5, 2020

Here is the summary of changes.

You added 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label.

@shaffeeullah
Copy link
Contributor

@AVaksman can this be merged?

@AVaksman
Copy link
Contributor Author

@AVaksman can this be merged?
Yes, it is ready to be merged.
Thank you

@shaffeeullah shaffeeullah merged commit 16b779d into googleapis:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Storage getFiles() documentation does not explain how to use pageToken
4 participants