Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update CopyOptions type to include cacheControl, contentType and contentEncoding #1426

Merged
merged 5 commits into from
Mar 23, 2021
Merged

fix: update CopyOptions type to include cacheControl, contentType and contentEncoding #1426

merged 5 commits into from
Mar 23, 2021

Conversation

shaffeeullah
Copy link
Contributor

As explained in #1422, File.copy already allows users to update these fields. It was missing documentation. This adds that documentation by adding those fields to the type & adds a system test for it.

Fixes: #1422 🦕

@shaffeeullah shaffeeullah requested a review from a team March 23, 2021 16:58
@shaffeeullah shaffeeullah requested a review from a team as a code owner March 23, 2021 16:58
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/nodejs-storage API. label Mar 23, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2021
@codecov
Copy link

codecov bot commented Mar 23, 2021 •
edited
Loading

Codecov Report

Merging #1426 (2128ba3) into master (1f63a82) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1426   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files          14       14           
  Lines       12155    12161    +6     
  Branches      530      530           
=======================================
+ Hits        12046    12052    +6     
  Misses        109      109
Impacted Files Coverage Δ
src/file.ts 99.94% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f63a82...2128ba3. Read the comment docs.

JustinBeckwith
JustinBeckwith approved these changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since this impacts types, I would classify it as a fix. We probably would want to include this in a changelog, because it has an impact on how the user would use the library.

@shaffeeullah shaffeeullah changed the title docs: update CopyOptions type to include cacheControl, contentType and contentEncoding fix: update CopyOptions type to include cacheControl, contentType and contentEncoding Mar 23, 2021
@shaffeeullah shaffeeullah merged commit efa5bb8 into master Mar 23, 2021
@shaffeeullah shaffeeullah deleted the shaffeeullah/updateCopyOptions branch March 23, 2021 17:44
@anantakrishna anantakrishna mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CopyOptions type to include cacheControl, contentType and contentEncoding
2 participants
@shaffeeullah @JustinBeckwith