r99584 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r99583‎ | r99584 | r99585 >
Date:22:16, 11 October 2011
Author:aaron
Status:ok
Tags:
Comment:
(bug 31489) - 'Logged-out users might overwrite earlier unsighted revisions due to oldid in edit link'. Quick fix to remove oldid=x from URL when viewing the stable version. At some point the 'edit' tab on stable versions changed to have the oldid due to core changes.
Modified paths:
  • /branches/wmf/1.18wmf1/extensions/FlaggedRevs/presentation/FlaggedPageView.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.18wmf1/extensions/FlaggedRevs/presentation/FlaggedPageView.php
@@ -1212,9 +1212,15 @@
12131213 if ( $pendingEdits ) {
12141214 if ( isset( $views['edit'] ) ) {
12151215 $views['edit']['text'] = wfMsg( 'revreview-edit' );
 1216+ if ( $this->showingStable() ) { // bug 31489
 1217+ $views['edit']['href'] = $skin->getTitle()->getFullURL( 'action=edit' );
 1218+ }
12161219 }
1217 - if ( isset( $views['viewsource'] ) ) {
 1220+ if ( isset( $views['viewsource'] ) ) { // bug 31489
12181221 $views['viewsource']['text'] = wfMsg( 'revreview-source' );
 1222+ if ( $this->showingStable() ) {
 1223+ $views['viewsource']['href'] = $skin->getTitle()->getFullURL( 'action=edit' );
 1224+ }
12191225 }
12201226 }
12211227 # Add "pending changes" tab if the page is not synced

Follow-up revisions

RevisionCommit summaryAuthorDate
r99614Ported in r99584 - 'edit' tab when viewing the stable revision should go to t...aaron01:07, 12 October 2011

Status & tagging log