-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for audio/video support in hub.ingest #2072
base: main
Are you sure you want to change the base?
Added support for audio/video support in hub.ingest #2072
Conversation
@FayazRahman can you review this? |
Hi @aadityasinha-dotcom Apologies for taking so long to respond to your PR. Are you still available to continue this work? |
@istranic yes!! |
@aadityasinha-dotcom ok great. I think next steps are:
|
Also @aadityasinha-dotcom is there a way to make this work will all file types that are supported in deeplake, not just audio+video? |
Also @aadityasinha-dotcom Can you rename the function to I'm asking this because we're focusing a lot more on speed, reliability, and scale, so everything needs to work with bigger workloads. |
Hey @aadityasinha-dotcom How's the progress on this PR. This is becoming quite high-priority internally, so just want to confirm it's moving along. If not, the current progress on this PR is really helpful, and our team can cake over and add some of the modifications I requested above. |
Hey @istranic, sorry been busy last week. I have worked on adding the tests and yes, it will be helpful if someone can do modifications. |
@aadityasinha-dotcom Got it, thx for the update. |
@istranic anything else left in this PR? |
@ProgerDav Can you pls look at this PR, since it's related to work you've been doing. How come full tests aren't running. |
deeplake.ingest( | ||
src=path, dest=path, progressbar=False, summary=False, overwrite=False | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In line 183 it says memory_path
is not defined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe because of the undeclared variable
🚀 🚀 Pull Request
Checklist:
coverage-rate
upChanges
Resolves #1556