Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Differentiability w.r.t what exactly? #58

Open
JonathanKuelz opened this issue Dec 12, 2023 · 2 comments
Open

Question: Differentiability w.r.t what exactly? #58

JonathanKuelz opened this issue Dec 12, 2023 · 2 comments

Comments

@JonathanKuelz
Copy link

Dear ADAM developers,

I just stumbled across your package and it looks amazing! However, there's a question I couldn't find an answer to in your examples and the README: If I am not mistaken, a JAX/PyTorch-implementation of the algorithms you included in ADAM should allow to compute gradients not only with respect to the joint configuration (as far as I understand, that's what you do in your examples), but leverage autograd to do so w.r.t any model parameter (e.g. joint offsets (aka link length) or inertial parameters).

Is that something that is supported by ADAM and if so, would you be so kind to provide me a pointer on where to start with something like that?

@JonathanKuelz JonathanKuelz changed the title Differentiability w.r.t what exactly? Question: Differentiability w.r.t what exactly? Dec 12, 2023
@traversaro
Copy link
Contributor

cc @Giulero @CarlottaSartore

@Giulero
Copy link
Collaborator

Giulero commented Dec 13, 2023

Hi @JonathanKuelz! Thanks for your interest and for opening the issue :)
You're right! This feature has been just introduced by @CarlottaSartore in #49.
We introduced a new module, adam.parametric.casadi/pytorch/etcetc, that computes rigid body algorithms using parametrized body information.
You can start to have a look at the tests, by checking the parametric tests folder to see how the methods are called.
Also, I'd warn that the pytorch/jax interfaces are not really stressed: if you have some doubts or spot bugs don't hesitate to come to us!

Btw, @CarlottaSartore will tell you more about the rationale behind the parametric module!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants