Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve concrete error message #22536

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Improve concrete error message #22536

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdks/go/pkg/beam/validate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ func makeTypedefs(list []TypeDefinition) (map[string]reflect.Type, error) {
if !typex.IsUniversal(v.Var) {
return nil, errors.Errorf("type var %s must be a universal type", v.Var)
}
if !typex.IsConcrete(v.T) {
return nil, errors.Errorf("type value %s must be a concrete type", v.T)
if ok, err := typex.CheckConcrete(v.T); !ok {
return nil, errors.Wrapf(err, "type value %s must be a concrete type", v.T)
}
typedefs[v.Var.Name()] = v.T
}
Expand Down