Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#28187][prism] Add a debugz page to standalone web ui. #28183

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

lostluck
Copy link
Contributor

@lostluck lostluck commented Aug 28, 2023

Add a page to the stand alone command that produces the various Go runtime metrics of the binary.

In particular, this includes the formatted goroutine dump, which can be useful in investigating stuck or unusually behaving jobs, when expanding prism's abilities.

Available at /debugz or from the link at the bottom of the index page.

Related to #28187.

image image image

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #28183 (6a6b09a) into master (e26735d) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #28183      +/-   ##
==========================================
+ Coverage   72.29%   72.31%   +0.01%     
==========================================
  Files         678      678              
  Lines       99848    99848              
==========================================
+ Hits        72189    72203      +14     
+ Misses      26084    26068      -16     
- Partials     1575     1577       +2     
Flag Coverage Δ
go 53.66% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label go.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jrmccluskey
Copy link
Contributor

Do you have an example of what the page looks like?

@lostluck lostluck changed the title [prism] Add a debugz page to standalone web ui. [#28187][prism] Add a debugz page to standalone web ui. Aug 28, 2023
@lostluck
Copy link
Contributor Author

Do you have an example of what the page looks like?

Screen shots added. Basically same formatting as the main and job details pages. Uses pre-formatted cells so the goroutine dump appears correctly.

Copy link
Contributor

@jrmccluskey jrmccluskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrmccluskey jrmccluskey merged commit 2d5aced into master Aug 28, 2023
10 checks passed
zechenj18 pushed a commit to zechenj18/beam that referenced this pull request Aug 29, 2023
lostluck added a commit to lostluck/beam that referenced this pull request Aug 30, 2023
@lostluck lostluck deleted the prismDebugz branch September 18, 2023 19:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants