-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#28187][prism] Add a debugz page to standalone web ui. #28183
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28183 +/- ##
==========================================
+ Coverage 72.29% 72.31% +0.01%
==========================================
Files 678 678
Lines 99848 99848
==========================================
+ Hits 72189 72203 +14
+ Misses 26084 26068 -16
- Partials 1575 1577 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Do you have an example of what the page looks like? |
Screen shots added. Basically same formatting as the main and job details pages. Uses pre-formatted cells so the goroutine dump appears correctly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add a page to the stand alone command that produces the various Go runtime metrics of the binary.
In particular, this includes the formatted goroutine dump, which can be useful in investigating stuck or unusually behaving jobs, when expanding prism's abilities.
Available at /debugz or from the link at the bottom of the index page.
Related to #28187.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.