Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Managed Iceberg] Support BigQuery Metastore catalog #32242

Merged
merged 11 commits into from
Aug 21, 2024

Conversation

ahmedabu98
Copy link
Contributor

  • Includes the BigQuery metastore catalog dependency (from gs://spark-lib/bigquery/iceberg-bigquery-catalog-1.5.2-0.1.0.jar)
    • Shades this jar to relocate conflicting guava dependency
  • Adds this dependency to the expansion service container
  • Adds read and write tests for BQMS catalog

…onflicts; add tests; add dependency to expansion service container
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ahmedabu98
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damondouglas for label java.
R: @damccorm for label build.
R: @johnjcasey for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98 ahmedabu98 added this to the 2.59.0 Release milestone Aug 21, 2024
Copy link
Contributor

@damccorm damccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one comment, please consider it non-blocking and feel free to either:

  1. Make the change and merge
  2. Skip the change and merge

sdks/java/io/expansion-service/build.gradle Outdated Show resolved Hide resolved
@ahmedabu98 ahmedabu98 merged commit 3bf2421 into apache:master Aug 21, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants